Sliding Window Counter Functionality Complete #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalarewicz
requested changes
Jul 16, 2022
Collaborator
shalarewicz
left a comment
shalarewicz
left a comment
There was a problem hiding this comment.
Great work! Minor change and one edge case to handle
evanmcneely
reviewed
Jul 19, 2022
Contributor
evanmcneely
left a comment
evanmcneely
left a comment
There was a problem hiding this comment.
Two additional things need to be done for this algorithm to integrate with the middleware to be used.
- In rate.limit.d.ts,
RateLimitOptions(line 51) needs to include configuration options for this rate limit algorithm. Create a new interface with configuration options and add it here. - In rateLimitSetup.ts, add the instantiation for this rate limiting class in the appropriate location.
evanmcneely
requested changes
Jul 19, 2022
Contributor
evanmcneely
left a comment
evanmcneely
left a comment
There was a problem hiding this comment.
Just marking this as requesting changes for previous comment
evanmcneely
approved these changes
Jul 22, 2022
shalarewicz
approved these changes
Jul 25, 2022
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The sliding window counter is completed and passing all tests.
Type of Change
Issues
#65
Evidence