check-is-client #11
Merged
check-is-client #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Louka3
approved these changes
Dec 2, 2023
ash-t-luu
added a commit
that referenced
this pull request
Jan 29, 2024
… updated babel/parser, took out comments in test files, added paths to exclude complie in tsconfig, note: test 14 is not fully working
ash-t-luu
added a commit
that referenced
this pull request
Feb 2, 2024
ash-t-luu
added a commit
that referenced
this pull request
Feb 3, 2024
…testing for #11-14, changed logic in parser to account for all function declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Issue Type
Description
Wrote a function getCallee that checks each file node and determines if hooks are utilized in the file, which returns a boolean and changes the value of the isClientComponent key on the tree node object.
Ticket Item
RL-23 - Determine if a node is a server or client component type in parser
Previous behavior
Did not have the functionality to determine client/server component type for each file.
Expected behavior
Now it has functionality for checking the type and assigning a property on each tree node to a boolean based on the result of the function getCallee.