Disabled draggable new edges #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o not allow pointer events on react-flow__handle.connectionindicator
Ponch49
approved these changes
Jan 23, 2024
Contributor
Ponch49
left a comment
Ponch49
left a comment
There was a problem hiding this comment.
Nice work Johnny!! Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Issue Type
Description
Removed ability to drag new edges from any currently used edge handles by styling the component <react-flow__handle.connectionindicator> directly to not allow pointer events.
Ticket Item
RL - 46
Steps to Validate Feature
Previous behavior
Hovering over edge handle would change pointer to crosshair then on click, hold, and drag and new edge would appear starting at edge handle and end at cursor. The new handle could not however be connected to anything as that event was also disabled.
Expected behavior
Now works as described above
Additional context
This change was made on the same branch as RL-45