Fl/rl 42 43 44/memory leak cleanup #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Issue Type
Description
After you close the initial Webview, any subsequent attempt to open another Webview was not allowed.
Steps to Reproduce Bug / Validate Feature / Confirm Tech Debt Fix
npm run webpackF5to open extension simulator.View Treein React Labyrinth extension and select root file.View Treeagain and select another file to make sure it allows for another Webview now.Previous behavior
Would not allow another Webview to be opened if initial Webview was disposed.
Expected behavior
Can now close initial Webview and as many webviews as you would like.
Screenshots & Videos
Webview.Bug.Fix.mov