AL/client conditionals #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updated babel/parser, took out comments in test files, added paths to exclude complie in tsconfig, note: test 14 is not fully working
…ls, to allow programmatic dissmisal of modal if no file was selected
…ons and added test suite in parser.test.ts
…ded my testing suite to this branch and files, all of the tests in 14 works except the component1. not sure why
…found based on the type. all the tests in tc_14 are now passing.
…testing for #11-14, changed logic in parser to account for all function declarations
Louka3
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Issue Type
Description
Working tests for #11-14. Modified config files and package.json to be ready for launch. Merged with updated code.
Ticket Item
RL-65: Add functionality to getComponentType to parse ExportDefaultDeclaration functions/components
RL-66: Add functionality to getComponentType to parse FunctionDeclaration
RL-56: TESTS #11-14
Expected behavior
Working tests for 11-14, updated parser logic for determining component type, changed showError to showNotification upon no file upload, updated package.json and other configs to be ready for production.