Skip to content

AL/tsconfig #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2024
Merged

AL/tsconfig #40

merged 1 commit into from
Feb 5, 2024

Conversation

@ash-t-luu
Copy link
Contributor

@ash-t-luu ash-t-luu commented Feb 4, 2024

Overview

Issue Type

  • Bug
  • Feature
  • Tech Debt

Description
Deleted unused images and added property in tsconfig to remove warnings and ignore node_modules/index.d.ts when running npx tsc

Steps to Validate Feature

  1. Run npx tsc
  2. Inspect the CLI
  3. You will see that there are no warnings regarding index.d.ts when checking for node_modules

Previous behavior
We had warnings when running npx tsc about repeating node_modules/index.d.ts with testing

Expected behavior
Now, no warnings will appear.

Louka3
Louka3 approved these changes Feb 4, 2024
View reviewed changes
Copy link
Contributor

@Louka3 Louka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ChristinaRaether ChristinaRaether merged commit 40eafa7 into dev Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Louka3 Louka3 Louka3 approved these changes

@ChristinaRaether ChristinaRaether ChristinaRaether approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ash-t-luu @Louka3 @ChristinaRaether