Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional access bar #14

Merged
merged 3 commits into from
Mar 3, 2020
Merged

Functional access bar #14

merged 3 commits into from
Mar 3, 2020

Conversation

kelvinscuesta
Copy link
Contributor

  • Converted class component to functional component
  • Learned how to use hooks (useState, useEffect, useRef, useHistory)
  • Refactored event handler logic
  • Fixed pathname bug

@johnsben002
@sirchensalot

kelvinscuesta and others added 3 commits March 2, 2020 12:31
@kelvinscuesta @johnsben002 @sirchensalot
Changed the links and started to functionalize the accessBar
e507863 
Co-authored-by: Ben Johnson <johnsben002@gmail.com>
Co-authored-by: William Chen <william.chen2179@gmail.com>
@kelvinscuesta @johnsben002
Hooks are working, but we need to fix the 1st dropdown on a fetch call
e0e0391 
Co-authored-By: Ben Johnson <johnsben002@gmail.com>
@kelvinscuesta @johnsben002
Working functional accessbar with hooks
355edad 
Co-authored-By: Ben Johnson <johnsben002@gmail.com>
johnsben002
johnsben002 approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@johnsben002 johnsben002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Fantastic work.

sirchensalot
sirchensalot approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@sirchensalot sirchensalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Them hooks!

@sirchensalot sirchensalot merged commit 74158b0 into dev Mar 3, 2020
@nabramow nabramow deleted the FunctionalAccessBar branch March 5, 2020 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirchensalot sirchensalot sirchensalot approved these changes

@johnsben002 johnsben002 johnsben002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelvinscuesta @sirchensalot @johnsben002