Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Enzyme test for AccessBarWithRouter #23

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Add Enzyme test for AccessBarWithRouter #23

merged 2 commits into from
Mar 4, 2020

Conversation

nabramow
Copy link
Contributor

@nabramow nabramow commented Mar 4, 2020

  • Added an Enzyme test that supports React Hooks for AccessBarWithRouter to check that hidden h1 renders on initial load

sirchensalot
sirchensalot approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@sirchensalot sirchensalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

johnsben002
johnsben002 approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@johnsben002 johnsben002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work editing the tests to work with react router!

@sirchensalot sirchensalot merged commit d8cae2a into dev Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirchensalot sirchensalot sirchensalot approved these changes

@johnsben002 johnsben002 johnsben002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nabramow @sirchensalot @johnsben002