Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

false positive on mapillary image detector - cycle infrastructure is tagged already #1011

Closed
matkoniecz opened this issue Oct 24, 2020 · 12 comments

Comments

@matkoniecz
Copy link
Contributor

http://osmose.openstreetmap.fr/pl/error/90514ca3-8c94-2d44-ba19-d4ce5392b0a5

OSM way with cycleway:left=opposite_lane and oneway:bicycle=no https://www.openstreetmap.org/way/25367091
screen

@matkoniecz matkoniecz changed the title false positive on mapillary image detector - cycle ingratructure is tagged already false positive on mapillary image detector - cycle infrastructure is tagged already Oct 24, 2020
@frodrigo
Copy link
Member

@frodrigo frodrigo added the bug label Oct 24, 2020
@matkoniecz
Copy link
Contributor Author

Does "highway": null, mean "any value of highway"?

@frodrigo
Copy link
Member

Does "highway": null, mean "any value of highway"?

Yes

@matkoniecz
Copy link
Contributor Author

I would add values opposite, opposite_lane in keys cycleway, cycleway:left and cycleway:right. Adding such values in cycleway:both seems not needed.

Also, lane in cycleway, cycleway:left, cycleway:right and cycleway:both.

I would recommend this as the image processing is quite poor and catches also cycleway signs denoting lanes (and white text on blue shops signs and logos of motorway payment scheme in Poland - but that is harder to avoid false positives in such cases :) )

@frodrigo frodrigo added the ready label Oct 24, 2020
frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Oct 24, 2020
@Famlam
Copy link
Collaborator

Famlam commented Oct 24, 2020

Ehm, may I vote against this?

Lane is significantly different from tracks, to my knowledge not signposted normally. The sign pictured seems to be a clear false positive detection of Mapillary.

(Same as oneway tags aren't indicating cycling infrastructure, but detecting them as such will miss actual missing cycling tracks)

(Also, cycleway:left/right=opposite_* has no meaning)

@Famlam
Copy link
Collaborator

Famlam commented Oct 24, 2020

It might be more convenient to teach Mapillary about those False Positives. Did something similar for NL a while ago.

@frodrigo
Copy link
Member

I prefer avoiding false positives by making more matching than necessary. It also should be tolerant to alternative and old mapping rules (like cycleway:left/right=opposite_*).

@Famlam
Copy link
Collaborator

Famlam commented Oct 24, 2020

Perhaps it's possible to exclude a.o. The Netherlands from these oneway exceptions then? Almost all our residential roads have oneway-exclusions, and since these connect to the roads with bicycle tracks...

Or, perhaps a better idea: make the less-strict one for level "medium" and the more strict (current) one for level "low"

frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Oct 25, 2020
frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Oct 25, 2020
frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Oct 25, 2020
jocelynj added a commit that referenced this issue Oct 25, 2020
* frodrigo/master:
  Add public jupyter setup
  Review docker volumes
  Switch Docker to Postgres 13 and PostGIS 3.0
  Fix docker-compose.yml for osmose container
  Add default Jupyter config
  Update JOSM MapCSS #1013
  Update to new data in analyser_merge_public_equipment_FR_toulouse_toilets
  Update data definition in analyser_merge_parking_FR_bm
  Update data definition in analyser_merge_street_number_bordeaux
  Fix Administrative_INSEE_Name.py init for new sax plugin load
  Init plugins from constructor
  Remove unused pugin.end()
  Revert 'Remove plugins load from __enter__'
  Withelist from landuse=water to natual=water #265
  More cycle infrastructure in mapillary-traffic-signs.mapping.json #1011
  value_replace also for array in analyser_merge_traffic_signs
@frodrigo
Copy link
Member

http://osmose.openstreetmap.fr/en/errors/?item=8470
Update in progress

@masterofnoroad
Copy link

Including highway=* + bicycle=designated results in not showing erroneus tagging: highway=footway + bicycle=designated (this combination is not treated as cycleway in most routing engines

@frodrigo
Copy link
Member

@masterofnoroad bad tag combination should be deal in other analyser, like this one
https://github.com/osm-fr/osmose-backend/blob/master/plugins/Bicycle.validator.mapcss
Please, open new issues for that.

@matkoniecz
Copy link
Contributor Author

Note https://josm.openstreetmap.de/ticket/17901 https://josm.openstreetmap.de/ticket/9250 and related issues and commits.

JOSM started to complain about highway=footway + bicycle=designated (after my request), in the end it was reverted as it was considered as a valid tagging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants