Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worldwide church names are reported as having a 'descriptive' name and 'unnecessary' #1303

Closed
sekerob opened this issue Jul 16, 2021 · 6 comments

Comments

@sekerob
Copy link

sekerob commented Jul 16, 2021

Please follow the discussion on OSM Help describing the problem. Tests were made to include the London Westminster Cathedral. All are being flagged with the same tagging problem.
[
Link: https://help.openstreetmap.org/questions/81001/church-name-suddenly-reported-as-unnecessary

@sekerob sekerob changed the title Worldwide church names are reported as having a 'descriptive' name and 'unncessary' Worldwide church names are reported as having a 'descriptive' name and 'unnecessary' Jul 16, 2021
@frodrigo
Copy link
Member

This rule come from JOSM Validator MapCSS
https://josm.openstreetmap.de/browser/josm/trunk/resources/data/validator/unnecessary.mapcss

cc @Klumbumbus

Not sure why it is triggered by the rule.

But I am agree with it. The "Westminster Cathedral" name is something like "Metropolitan Cathedral of the Precious Blood of Our Lord Jesus Christ".
https://en.wikipedia.org/wiki/Westminster_Cathedral

@Klumbumbus
Copy link

There is probably something wrong on the osmose side. Within JOSM there is no warning about descriptive name for https://www.openstreetmap.org/way/10810446 (Westminster Cathedral)

@frodrigo
Copy link
Member

amenity=place_of_worship
name=Westminster Cathedral

These tags match this rule due to bad scoped OR in the last condition on generated python code.

*[name][name=~/^(?i)(chapel|chapelle|kapelle)$/][tag("building")=="chapel"||tag("amenity")=="place_of_worship"]

frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Jul 17, 2021
jocelynj added a commit that referenced this issue Jul 17, 2021
* frodrigo/master:
  Fix test Josm_deprecated_test
  Add new deps for mypy
  Regenerate from mapcss after compilator fix #1303
  Fix predicat boolean scope in generated python code from mapcss #1303
  Update JOSM mapcss
@sekerob
Copy link
Author

sekerob commented Jul 17, 2021

Chapeau for dogging the issue, the quick diagnostics and fixing. Is there an ETA as to when this is going to translate into the few hundred thousand 'unnecessary' warning pins disappearing ;?

@frodrigo
Copy link
Member

frodrigo commented Jul 17, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants