Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Osmose reports several false positives for Philippine waterways not connected to coastline #1348

Closed
JAT86 opened this issue Oct 26, 2021 · 4 comments
Closed

Osmose reports several false positives for Philippine waterways not connected to coastline #1348

JAT86 opened this issue Oct 26, 2021 · 4 comments
Labels
bug ready

Comments

@JAT86
Copy link

JAT86 commented Oct 26, 2021

Related to #1331 , Osmose reports false positives of waterways not connected to coastline (Item 1220 - waterway). This is especially evident in the Philippines where both rivers and streams (waterway=river and waterway=stream) which are actually connected to multipolygon/relation island coastlines (natural=coastline) are reported as not connected to the coastline:

Kindly check and fix.
@frodrigo
Copy link
Member

Differential update on this should be studied and may be disabled.

@frodrigo
Copy link
Member

Found issue on diff mode. Wait for update.

@frodrigo frodrigo mentioned this issue Dec 27, 2021
Closed
frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Dec 27, 2021
@frodrigo
Remove diff mode in analyser_osmosis_waterway osm-fr#1348
bbc195d
jocelynj added a commit that referenced this issue Dec 27, 2021
@jocelynj
Merge remote-tracking branch 'frodrigo/master'
a4ddfa9 
* frodrigo/master:
  Also keep nature=Sommet for natural=peak #1354
  Remove diff mode in analyser_osmosis_waterway #1348
  Remove diff mode in analyser_osmosis_highway_features #1327
  mapcss: update
  mapcss: more flexible link selector
  Allow '/' in Denmark #1335
@frodrigo
Copy link
Member

Not sure about the fix
Update in progress
http://osmose.openstreetmap.fr/en/issues/open?item=1220&class=2,3

@frodrigo
Copy link
Member

Fixed, update in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ready
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frodrigo @JAT86