New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complains about maxwidth where no maxwidth tag is present #367

Open
matkoniecz opened this Issue Oct 24, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@matkoniecz
Contributor

matkoniecz commented Oct 24, 2018

source 8420
item 9006
class 9006005
subclass 1339141103
elems way623334957

tags according to osmose itself:

highway service  
maxheight below_default  
sidewalk no  
surface paving_stones  
tunnel building_passage  
vehicle private

https://www.openstreetmap.org/way/623334957

If my guess is correct and complaint is about maxheight - then note https://wiki.openstreetmap.org/wiki/Key:maxheight#Non-numerical_values - below_default is documented and sensible value (used by at least StreetComplete editor).

@frodrigo

This comment has been minimized.

Member

frodrigo commented Oct 24, 2018

Yes subclass 1339141103 is for maxheight.
The problem is only with the message.

@frodrigo frodrigo added the bug label Oct 24, 2018

@matkoniecz

This comment has been minimized.

Contributor

matkoniecz commented Oct 25, 2018

Are you sure that people should select "false positive" for every single maxheight=below_default?

@frodrigo

This comment has been minimized.

Member

frodrigo commented Oct 25, 2018

You're right. This value must be supported.
This rule com from JOSM validator:
https://josm.openstreetmap.de/browser/josm/trunk/data/validator/numeric.mapcss#L92

cc @Klumbumbus

@frodrigo frodrigo added the JOSM label Oct 25, 2018

@Klumbumbus

This comment has been minimized.

simon04 pushed a commit to openstreetmap/josm that referenced this issue Oct 25, 2018

floscher pushed a commit to floscher/josm that referenced this issue Oct 25, 2018

frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Oct 26, 2018

@frodrigo

This comment has been minimized.

Member

frodrigo commented Oct 26, 2018

Update MapCSS code from JOSM.

Remain the issue of bad label.

frodrigo added a commit to frodrigo/osmose-backend that referenced this issue Oct 28, 2018

jocelynj added a commit that referenced this issue Oct 28, 2018

Merge remote-tracking branch 'frodrigo/master'
* frodrigo/master:
  Fix Analyser_Merge for Postgres 10
  Fix SQL in analyser_osmosis_relation_public_transport
  Also look at highway=mini_roundabout for roundabout in mapillary-traffic-signs.mapping.json #359
  Allow sidewalk construction in Bicycle.mapcss #361
  Better desc in TagFix_MultipleTag #362
  Update MapCSS from JOSM #367
  Update github issue_template.md
  Better desc & text in TagRemove_Fixme #365
  Better desc in analyser_osmosis_parking_highway #366
  Set level=2 to 2110/21101 #370
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment