Prevent false positives tag typo (rhn_ref etc.)
#938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frodrigo
reviewed
Aug 2, 2020
|
Analyser based on SQL does not have unit test. |
Excludes a number of tags used in mapping regional hiking/cycling/etc from the typo query. routes from being seen as typos. The lesser used tags, such as `rhn_ref` (for horse riding routes) got flagged as possible typos of the more common ones (i.e., `rwn_ref`).
jdhoek
force-pushed
the
bug/rhn_ref_is_a_typo
branch
from
063a5e6
to
427f29a
Compare
frodrigo
reviewed
Aug 2, 2020
|
Thank. Merged, but not deployed, yet. |
|
Thanks. |
|
Deployed |
|
Probably, cannot tell, you removed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Excludes a number of tags used in mapping regional hiking/cycling/etc from the typo query. routes from being seen as typos. The lesser used tags, such as
rhn_ref(for horse riding routes) got flagged as possible typos of the more common ones (i.e.,rwn_ref).I know of six types of regional routing network that are currently in active use on OSM:
rcn(cycling)rhn(horse riding)rin(inline skating)rmn(motorboating)rpn(canoeing/kayaking)rwn(walking/hiking)This PR takes the most common tags used in these networks, and excludes them from the query following the example of the existing exclusions in
sql10.This issue was spotted in the Dutch OSM community.
I think this PR should properly exclude those tags from the typo analysis, but I couldn't find a place to add a test that verifies this in the pytest suite. Does this analyser have any unit tests?
Could someone confirm that this PR works
and perhaps show me how to cover it with a unit test?