New turn lanes conception #17421
Merged
New turn lanes conception #17421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vshcherb
reviewed
Jun 16, 2023
| }}; | ||
| Set<Integer> sharpRightDirections = new HashSet<Integer>(){{ | ||
| add(TurnType.TSHR); | ||
| add(TurnType.TRU); |
There was a problem hiding this comment.
something could be wrong TRU = TU in data so it might not work as expected
There was a problem hiding this comment.
Here is compare with syntetic mainTurnType that calculated using angles. Just to know if we select right direction.
vshcherb
reviewed
Jun 16, 2023
| } | ||
| boolean left = TurnType.isLeftTurnNoUTurn(mainTurnType); | ||
| boolean right = TurnType.isRightTurnNoUTurn(mainTurnType); | ||
| Set<Integer> leftDirections = new HashSet<Integer>(){{ |
There was a problem hiding this comment.
Why is it needed if there are methods TurnType.isLeftTurnNoUTurn - too much copy / paste
vshcherb
reviewed
Jun 16, 2023
| } | ||
| } | ||
| TurnType t = TurnType.valueOf(tp, leftSide); | ||
| if (cnt == 3 && TurnType.isSlightTurn(t.getValue())) { |
There was a problem hiding this comment.
here we need to add comment what 3 means
There was a problem hiding this comment.
vshcherb
reviewed
Jun 16, 2023
| } | ||
| int[] uniqTurnTypes = getUniqTurnTypes(turnLanesPrevSegm); | ||
| for (int lane : uniqTurnTypes) { | ||
| if (lane == TurnType.TSHL || lane == TurnType.TSHR || lane == TurnType.TU || lane == TurnType.TRU) { |
There was a problem hiding this comment.
Same method as below could be added TurnType.sharpOrReverse(..)
This was referenced Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main issue #15930
Other issues #17238
#16752 (comment)