Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn lane assist errors #3347

Closed
skylerbunny opened this issue Dec 14, 2016 · 7 comments
Closed

Turn lane assist errors #3347

skylerbunny opened this issue Dec 14, 2016 · 7 comments
Assignees
Milestone

Comments

@skylerbunny
Copy link

Now that #3052 is fixed, another couple smaller errors have made themselves obvious.

Routing from (47.3978387, -122.2920164) to (47.3958035, -122.2985595):

  1. While on segment 265726357, turn:lanes is ( ||||through;slight_right|slight_right )
    a. Given assistance is (no | no | no | no | no | slight_right )
    b. Expected assistance is ( no | no | no | no | slight_right | slight_right) - in other words, both lanes should be suggested since they both contain the same arrow suggestion, even though one is a combination arrow.

  2. After turning from segment 234663067 to 286359390, an upcoming turn:lanes (on segment 265002601 is ( left|left| ) ).
    a. Given assistance is (left | no | no ). A 'turn left' vocal instruction is not given, but the lane assist highlights that left turn lane.
    b. Expected assistance is ( no | no | through ). This is particularly true since once the driver passes node 2713506156, the left turn instruction clears, and now (correctly) tells the driver to be in the through lanes to proceed through the upcoming intersection. The aforementioned was fixed by Turn lane assist oddity #3052.

Apologies if any of this is unclear; if clarification is needed I'll be happy to do my best to provide it.

@hakuchi
Copy link
Contributor

hakuchi commented Dec 14, 2016

There are no voice prompts for left/right turn lanes:
use left lane, use right lane, use slight left lane or use two left lanes, use one left lane, or something similar.
Thus, the voice prompts says how many lanes are and you do not have to constantly check the screen.
Some motorway is splitting in a Y-junction into two motorways(1|2), but on these turn lanes are no voice prompts.

@xmd5a2
Copy link
Contributor

xmd5a2 commented Jan 13, 2017

Test added

@vshcherb
Copy link
Member

The issue is duplicate to what already fix (forgot the number, please add link if someone knows). The restriction is missing, it should be forbidden to turn right from (way 222243, left|left|through|through, South Kent Des Moines Road, http://www.openstreetmap.org/way/265002602) to Pacific Highway South .
@xmd5a2 Please add relation restriction and the test should be fixed.

@skylerbunny
Copy link
Author

The issue vscherb refers to is #3052 , which I reported myself and which was properly fixed in osmand. The restriction requested is http://www.openstreetmap.org/relation/6596913 which has been in place for four months.

That said, this is a completely different problem, involving 'osmand' offline navigation and the in-app 'lanes' alerts which appear when one navigates using that navigation method. Those alerts use the 'turn:lanes' keys and values.

In the original stated issue above in #3347, (2), I am saying that although no turn instructions are given (and in fact the correct instruction or lack thereof, 'continue straight', applies thanks to the fix in #3052 ), the lanes alert is suggesting the driver be in a left turn only lane, which makes no sense.

@skylerbunny
Copy link
Author

2017-03-21 16 22 19
2017-03-21 16 22 26
2017-03-21 16 22 35

Uploaded three images to visually describe the problem. In the second of the three, a person is told to get into the 'rightmost left turn lane' and they shouldn't be, since the next lanes instruction is to get into the straight-ahead lane.

@vshcherb vshcherb added this to the 2.6.1 milestone Mar 25, 2017
@vshcherb vshcherb self-assigned this Mar 25, 2017
@vshcherb
Copy link
Member

@hakuchi in your example there is a split from motorway -> motorway, motorway_link. These interesctions are not speakable if you keep riding motorway in most of the cases it is intended behavior though it might not be in that case. The solution could be to switch small segment to motorway or to motorway_link

@vshcherb
Copy link
Member

vshcherb commented Apr 3, 2017

Some improvements has been made (so it fixes several issues). Though main issue unfortunately not possible to fix for now
http://www.openstreetmap.org/way/265002601
This road splits into segments: main road and turn right. Unfortunately neither of lanes "left|left|straight" indicates right road segment. This is not supported by algorithm.

Shortly saying, if turn_lanes="left|left|straight;turn_right" (which reflects reality but slightly differs from the ground truth), then the bug is fixed and OsmAnd will correctly display "TL|TL|+C;TR" and so on. Otherwise that issue will stay as it is.

@vshcherb vshcherb closed this as completed Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants