libosmiun 2.14.1 io_test_pbf & io_test_reader fail on big endian architecture (PBF error: invalid BlobHeader size (> max_blob_header_size))

[sebastic]

The endian changes in 2.14.1 caused a regression, the tests fail on big endian systems (s390x, powerpc, mips. m68k):

49: Test command: /<<PKGBUILDDIR>>/build/test/io_test_pbf
49: Environment variables: 
49:  OSMIUM_TEST_DATA_DIR=/<<PKGBUILDDIR>>/test
49: Test timeout computed to be: 10000000
49: 
49: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
49: io_test_pbf is a Catch v1.12.1 host application.
49: Run with -? for options
49: 
49: -------------------------------------------------------------------------------
49: Read PBF file with version=-1 and changeset=-1 (written by Osmosis)
49: -------------------------------------------------------------------------------
49: /<<PKGBUILDDIR>>/test/t/io/test_pbf.cpp:20
49: ...............................................................................
49: 
49: /<<PKGBUILDDIR>>/test/t/io/test_pbf.cpp:20: FAILED:
49: due to unexpected exception with message:
49:   PBF error: invalid BlobHeader size (> max_blob_header_size)
49: 
49: -------------------------------------------------------------------------------
49: Read PBF file with version=-1 and changeset=-1 and DenseNodes (written by
49: Osmosis)
49: -------------------------------------------------------------------------------
49: /<<PKGBUILDDIR>>/test/t/io/test_pbf.cpp:39
49: ...............................................................................
49: 
49: /<<PKGBUILDDIR>>/test/t/io/test_pbf.cpp:39: FAILED:
49: due to unexpected exception with message:
49:   PBF error: invalid BlobHeader size (> max_blob_header_size)
49: 
49: ===============================================================================
49: test cases: 2 | 2 failed
49: assertions: 2 | 2 failed
49: 
 49/156 Test  #49: io_test_pbf ..................................***Failed    0.00 sec
test 50
        Start  50: io_test_reader

50: Test command: /<<PKGBUILDDIR>>/build/test/io_test_reader
50: Environment variables: 
50:  OSMIUM_TEST_DATA_DIR=/<<PKGBUILDDIR>>/test
50: Test timeout computed to be: 10000000
50: 
50: ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
50: io_test_reader is a Catch v1.12.1 host application.
50: Run with -? for options
50: 
50: -------------------------------------------------------------------------------
50: Reader should decode zero node positions in history (PBF)
50: -------------------------------------------------------------------------------
50: /<<PKGBUILDDIR>>/test/t/io/test_reader.cpp:169
50: ...............................................................................
50: 
50: /<<PKGBUILDDIR>>/test/t/io/test_reader.cpp:169: FAILED:
50:   {Unknown expression after the reported line}
50: due to unexpected exception with message:
50:   PBF error: invalid BlobHeader size (> max_blob_header_size)
50: 
50: ===============================================================================
50: test cases: 18 | 17 passed | 1 failed
50: assertions: 45 | 44 passed | 1 failed
50: 
 50/156 Test  #50: io_test_reader ...............................***Failed    0.01 sec
test 51
        Start  51: io_test_reader_fileformat

Full buildlogs: s390x, powerpc, mips, m68k

[sebastic]

Thanks for the quick response, the change has been included as patch in the Debian package, and fixed the issue on s390x, powerpc & mips. The build results for m68k are not in yet, bust most probably fixed too.