Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_location_tuple fails (AssertionError: 'n0 v0 dV c0 t i0 u T x1 y2' != 'n0 v0 dV c0 t i0 u T x1.0000000 y2.0000000') #15

Closed
sebastic opened this issue Jun 29, 2016 · 2 comments

Comments

@sebastic
Copy link
Contributor

commented Jun 29, 2016

As reported by Santiago Vila in Debian Bug #828979:

Dear maintainer:

This package currently fails to build in stretch:

[...]
FAIL: test_location_tuple (test_writer.TestWriteNode)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/build/pyosmium-2.7.1/test/test_writer.py", line 112, in test_location_tuple
    w.add_node(O(location=(1, 2)))
  File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
    self.gen.next()
  File "/build/pyosmium-2.7.1/test/test_writer.py", line 35, in WriteExpect
    assert_equals(line, expected)
AssertionError: 'n0 v0 dV c0 t i0 u T x1 y2' != 'n0 v0 dV c0 t i0 u T x1.0000000 y2.0000000'

A full build log is available here:

https://tests.reproducible-builds.org/debian/rbuild/testing/amd64/pyosmium_2.7.1-2.rbuild.log

Thanks.

Several of the pyosmium dependencies have been changed in the mean time, but I suspect changes in Python 2.7.12-rc1 are the cause of this issue (Python 2.7.11 was used before).

sebastic added a commit to sebastic/pyosmium that referenced this issue Jul 4, 2016
@sebastic

This comment has been minimized.

Copy link
Contributor Author

commented Jul 4, 2016

The change in #16 fixes the test failure on Debian stable & unstable, I'm not entirely sure if it's the appropriate fix for this issue though.

@lonvia

This comment has been minimized.

Copy link
Member

commented Jul 11, 2016

The OPL output format for coordinates has changed in libosmium 2.7.2. It is used in that particular test to check the writer output. I see if I can modify the test so that runs okay against all 2.7.x versions of libosmium.

lonvia added a commit that referenced this issue Jul 11, 2016
writer test: use coordinates that avoid zero-padding
Takes into account a format change in OPL format where coordinates
are now zero-padded.

Fixes #15.

@lonvia lonvia closed this in a75ec8d Jul 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.