New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant test target #1058

Closed
cbalster opened this Issue Jun 8, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@cbalster
Contributor

cbalster commented Jun 8, 2018

Issue Type

[x] Improvement
[x] Build system related
[x] Performance

Description and/or steps/code to reproduce the problem

As far as I can tell the build target 11 is redundant since target 1 already is api 8. The "g" variant is only used for building the GoogleWrapperSample but this is minSdk = 9 and therefore is excluded anyway.
See:

- API=8g ANDROID_TARGET=11 ANDROID_ABI=armeabi

and

Version of osmdroid the issue relates to:

master

@spyhunter99

This comment has been minimized.

Collaborator

spyhunter99 commented Jun 9, 2018

good catch. actually i'm probable going to drop the google stuff from the settings.gradle file and be done with it, then the travis script can be further reduced. We really need avds on travis that work. It's only a matter of time before the google overlords remove the api8 images entirely from the download catalog

@cbalster

This comment has been minimized.

Contributor

cbalster commented Jun 9, 2018

I'm actually cleaning up parts of the travis build right now and will try to get newer avds working again. I'll let you know what I was able to do.

@spyhunter99

This comment has been minimized.

Collaborator

spyhunter99 commented Jun 9, 2018

good luck, i've attempted it countless times, always ending in defeat.

@cbalster

This comment has been minimized.

Contributor

cbalster commented Jun 16, 2018

Just a quick update: I got things working again for the most part and also was able to shave off a bit on build times. It's mostly a matter of sorting out some minor details now and cleaning up my branch. I'm a bit short on time currently but I hope to PR some time next week.

@cbalster cbalster referenced this issue Jun 24, 2018

Merged

Feature/#1058 #1068

spyhunter99 added a commit that referenced this issue Jun 30, 2018

Feature/#1058 (#1068)
* Use properties for lib versions in build files

* Increase JVM memory to allow for dexinprocess

as it improves build times

* Overhaul travis build

- rework the way build environments are configured
- only download required components and emulator images when they are
  required (on a per worker basis). This significantly improves build
  times. As a side effect this requires to switch to google's repos for
  most of the downloads.
- spin up the emulator before starting the build to use the time to let
  it boot. Tests are run afterwards. Slightly improves build time.
- general cleanup
- switch to openjdk8

* Work around SSLExceptions on some emulator images

Some emulator images do not update their time/date correctly and stay
on 0 unix time. This causes SSLExceptions due to the validity of the
certificates. This works around this issues by using http.

* Fix test_getMapTile_found()

Test fails on some emulators due to:
"java.io.IOException: open failed: EROFS (Read-only file system)"
getFilesDir() should always be writable.

* Remove unneeded travis configurations

Since osmdroid-third-party and GoogleWrapperSample are deactivated,
addons and several test targets can be removed. Keeps API23 google api
since there is no default image.

* Disable currently failing builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment