New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to target api 26 to comply with playstore rules #1098

Closed
spyhunter99 opened this Issue Jul 16, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@spyhunter99
Collaborator

spyhunter99 commented Jul 16, 2018

Please note: issues related to or caused by osmbonuspack will be closed with a
suggestion to open an issue at https://github.com/MKergall/osmbonuspack

(feel free to delete whatever doesn't apply)

Issue Type

[ ] Question
[ ] Bug
[ ] Improvement
[ x] Build system related
[ ] Performance
[ ] Documentation

spyhunter99 added a commit that referenced this issue Jul 16, 2018

spyhunter99 added a commit that referenced this issue Jul 16, 2018

spyhunter99 added a commit that referenced this issue Jul 17, 2018

spyhunter99 added a commit that referenced this issue Jul 17, 2018

spyhunter99 added a commit that referenced this issue Jul 17, 2018

@neilboyd neilboyd changed the title from Update to target api 26 to compile with playstore rules to Update to target api 26 to comply with playstore rules Jul 17, 2018

@cbalster

This comment has been minimized.

Contributor

cbalster commented Oct 24, 2018

Since this is becoming a problem for the demo app by the end of the month, I was wondering if there is any progress on this?
If I remember correctly the main problem here is gradlefury not working with gradle => 3.4 which prevents updating the support libs/build tools since they at some point require higher versions of gradle. Any chance of making gradlefury work with newer gradle versions?

@spyhunter99

This comment has been minimized.

Collaborator

spyhunter99 commented Oct 24, 2018

@spyhunter99

This comment has been minimized.

Collaborator

spyhunter99 commented Nov 21, 2018

looking into it now. just did a test build. sonatype fails us on both javadocs and sources jar missing on the jre tile packager.

@spyhunter99

This comment has been minimized.

Collaborator

spyhunter99 commented Nov 21, 2018

success, wasn't too bad actually

spyhunter99 added a commit that referenced this issue Nov 21, 2018

@spyhunter99 spyhunter99 added this to the v6.0.3 milestone Nov 21, 2018

spyhunter99 added a commit that referenced this issue Nov 24, 2018

Bug/#1098 - Bump support lib to 26 (#1204)
* Bump support lib version to match compileSdk

24.2.0 deprecates support for API 8 and lower
26.0.0 raises minSDK to 14

So basically to be able to upgrade and comply with the playstore
rules minSDK MUST be raised to 14!

osmdroid-android doesn't have any dependencies to the support lib,
so we can leave the main minSDK at 8 and only set it to 14 for the
packages that do require support libraries (MapViewer, simple-map,
wms). This way the core lib will remain compatible down to API 8.
BUT this also means that running tests on AVDs below 14 will not be
possible and thus compatibility for API<14 will no longer be tested!

* Bump LeakCanary version to remove compiler warnings

* Manifest cleanup

values are overridden anyway by values set in build.gradle

* Mark license texts as non-translatable

to prevent lint warnings

* Fix travis build without signing config

In https://raw.githubusercontent.com/gradle-fury/gradle-fury/v1.1.4/gradle/android-support.gradle
we have a hack to prevent builds from failing due to missing signing
config. This is done by removing the signing task from the build if
no keystore/pass is provided.

At some point the signing task has been renamed from
"validateReleaseSigning" to "validateSigningRelease", thus obviously
breaking the build again.

This simply adds a copy of the relevant code from
android-support.gradle adapted to the new name.

This should be cleaned up in the future!

* Update Robolectric to fix build error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment