New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Cleanup #1214

Closed
cbalster opened this Issue Nov 28, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@cbalster
Copy link
Contributor

cbalster commented Nov 28, 2018

Issue Type

[x ] Improvement

Description and/or steps/code to reproduce the problem

There's quite a lot of misc cleanup to be done that accumulated over time.
This seems like a good time for a first step.

Version of osmdroid the issue relates to:

6.0.3

spyhunter99 added a commit that referenced this issue Dec 13, 2018

Bug/#1214 -General cleanup (#1215)
* android-wms cleanup

- no appcompat needed
- no robolectrix needed
- custom runner is not used

* osmdroid-simple-map cleanup

- switch to appcompat
- misc cleanup

* mapsforge cleanup

* geopackage cleanup

remove unnecessary imports

* tilpackager cleanup

* OpenStreetMapViewer cleanup

- remove unnecessary imports
- remove unnecessary casts
- remove unnecessary modifiers
- remove obsolete SDK checks
- misc

@spyhunter99 spyhunter99 added this to the v6.1.0 milestone Dec 13, 2018

@monsieurtanuki

This comment has been minimized.

Copy link
Collaborator

monsieurtanuki commented Dec 16, 2018

I guess it's done now, isn't it?

@cbalster

This comment has been minimized.

Copy link
Contributor

cbalster commented Dec 18, 2018

There is more to do but this can be closed after #1215

@cbalster cbalster closed this Dec 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment