Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Zoom refactoring #1418

monsieurtanuki opened this issue Oct 9, 2019 · 1 comment


Copy link

@monsieurtanuki monsieurtanuki commented Oct 9, 2019

Issue Type

  • Improvement

Description and/or steps/code to reproduce the problem

Cf. #1414


If it's a bug, version(s) of android this affects:


Version of osmdroid the issue relates to:


monsieurtanuki added a commit that referenced this issue Oct 9, 2019
…rd zoom controllers

Impacted classes:
* `AsyncTaskDemoFragment`, `CustomRecycler`, `SampleFollowMe`, `SampleHeadingCompassUp`, `SampleSplitScreen`, `WeathForceActivity`: removed a useless call to now deprecated method `MapView.setBuiltInZoomControls`, which used to be the default behavior anyway
* `MapView`: removed all the references on the deprecated Android zoom controls; moved the calls to zoom control test in `dispatchTouchEvent`; deprecated method `setBuiltInZoomControls`; unrelated minor refactoring
* `CustomZoomButtonsController`: made `public` method `isTouched` which uses new method `CustomZoomButtonsDisplay.isTouched`; deprecated method `onSingleTapConfirmed` and `onLongPress`
* `CustomZoomButtonsDisplay`: deprecated method `isTouchedRotated` as we now check the touch event before applying the rotation; created method `isTouched(MotionEvent,boolean)` for the same reasons; unrelated minor refactoring
monsieurtanuki added a commit that referenced this issue Oct 14, 2019
feature/#1418 - custom zoom refactoring while removing the old standard zoom controllers

This comment has been minimized.

Copy link
Collaborator Author

@monsieurtanuki monsieurtanuki commented Oct 21, 2019

Coded in #1419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.