Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizing CacheManager UI #315

Closed
2ndGAB opened this issue May 27, 2016 · 10 comments
Closed

Customizing CacheManager UI #315

2ndGAB opened this issue May 27, 2016 · 10 comments

Comments

@2ndGAB
Copy link

2ndGAB commented May 27, 2016

Hello spyhunter99,

Maybe I didn't well explained my needs on that point MKergall/osmbonuspack#231, because I took a look at the application sample but I didn't see how to customize the downloading message.

I mean this dialog: Imgur

So I suggested to pass the progressDialog to CacheManagerTask.

@spyhunter99
Copy link
Collaborator

It looks like a protected string sets the "Handling zoom" message. Extend
the class and override it.

On Fri, May 27, 2016 at 6:18 AM, Alain notifications@github.com wrote:

Hello spyhunter99,

Maybe I didn't well explained my needs on that point
MKergall/osmbonuspack#231
MKergall/osmbonuspack#231, because I took a
look at the application sample but I don't see how to customize the
downloading message.

I mean this dialog: Imgur http://i.imgur.com/oxR6FRK.png

So I suggested to pass the progressDialog to CacheManagerTask.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#315, or mute the thread
https://github.com/notifications/unsubscribe/AB4kGXR6IMtqZ8OFvQIZQw4sYExHra1eks5qFsT1gaJpZM4IoXYE
.

@2ndGAB
Copy link
Author

2ndGAB commented May 28, 2016

Hi Spyhunter,
Sorry but that's not enough, I'd want to set my own title, maybe ues a non cancelable progressDialog, etc...
Again, passing our own dialog would be fine.

@spyhunter99
Copy link
Collaborator

spyhunter99 commented May 29, 2016

hmmk, i don't have a lot of free time at the moment. Feel free to open a PR for this.

Edit: i definitely see a use case for this

@spyhunter99
Copy link
Collaborator

Maybe we can change cachemanager to just do the work and have the UI be optional. That may be a better solution

@spyhunter99
Copy link
Collaborator

@2ndGAB please check out the delta's with that commit and the example. if you're ok with it and it meets the needs (and hopefully future needs) and the build passes, i'll merge it

@2ndGAB
Copy link
Author

2ndGAB commented May 30, 2016

I saw that you added a boolean to not use ant UI.
Ok, that could be useful but the problem is that prevent to have any progress.
So, would it be possible to pass our ProgressDialog as parameter.
If this parameter is null, you use your ProgressDialog, if the parameter is non null, you use our ProgressDialog with our title, message, etc..

@spyhunter99
Copy link
Collaborator

Check out the example to, it's a custom ui with progress
On May 30, 2016 2:36 AM, "Alain" notifications@github.com wrote:

I saw that you added a boolean to not use ant UI.
Ok, that could be useful but the problem is that prevent to have any
progress.
So, would it be possible to pass our ProgressDialog as parameter.
If this parameter is null, you use your ProgressDialog, if the parameter
is non null, you use our ProgressDialog with our title, message, etc..


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#315 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AB4kGcqqJR2vxf_nqSF6FFRIRlbvZ5Ujks5qGoVbgaJpZM4IoXYE
.

@2ndGAB
Copy link
Author

2ndGAB commented May 31, 2016

Ok I check it today

@2ndGAB
Copy link
Author

2ndGAB commented Jun 1, 2016

Hi Spyhunter99,
I've implemented it and for me everything is ok.
Many thanks!!

spyhunter99 added a commit that referenced this issue Jun 4, 2016
@spyhunter99
Copy link
Collaborator

merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants