New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VOTE] osmdroid v6.0.0 release #914

Closed
spyhunter99 opened this Issue Feb 3, 2018 · 13 comments

Comments

Projects
None yet
@spyhunter99
Collaborator

spyhunter99 commented Feb 3, 2018

osmdroid has had a ton of new committers and contributors lately, Thank you all so much for your hard work! I feel that we are near ready for a release. It's been a long time since 5.6.5 and we are well past due. That said, osmdroid has never really had an governance processes (that I know of), I figured we should start probably start with v6.0.0's release. It stands now at 88 closed issues for this release.

If you're new to open source governance, it's worth the time to read some of ASF's guidelines for releases, specifically decision making. Normally projects require a majority of the committers to have a +1 vote with no -1 votes.
This is used for lots of purposes in ASF but most commonly it is used for voting on a release. In the past, most of the conversation regarding cutting a new osmdroid release has been through email but there's probably a better way. We currently stand at about 10 individuals with commit privileges. Opening this up to the community makes sense as people do fun and creative things with maps and we don't always have test cases for everything (nor do we really know how it is used).

The best we have for group communication right now is google groups, which hardly anyone uses, so the next best option is to just use a github issue. Since v6.0.0 has significant changes, I'd like to open this one up for the broader community to test and/or provide feedback before we cut the final artifacts. As of this writing, osmdroid has 129 people watching this project and over 1200 stars. That's a 129 people that will get an email regarding this vote. If you don't make your voice heard than there's not much we can do about it.

That said, it would be nice if most recent committers vote an opinion and/or test results. Snapshots are up to date on central. According to github, here's some of the recent contributors

@Maradox @monsieurtanuki @MKergall @secaw @pasniak @cbalster @miguel-porto @shiroyagi
@neilboyd @k3b @kurtzmarc @jmarks213

So, when you have time, please comment below with a +1, 0, or -1 with explanation of what the issue is. Since everyone is probably super busy and working on open source is probably not a high priority for many, we'll keep the vote open for 2 weeks, ending on February 16, 2018 00:00 hrs UTC.

There is currently 1 pull request open which may resolve a bug with loading map tiles related to in memory caches. It's a rather large change set and although it may solve some issues, I have some minor concerns that there is a possibility that it may introduce unforeseen issues.

That's said, I'll happily give this a +1 from me.

@spyhunter99 spyhunter99 added the Vote label Feb 3, 2018

@spyhunter99 spyhunter99 added this to the v6.0.0 milestone Feb 3, 2018

@shiroyagi

This comment has been minimized.

Contributor

shiroyagi commented Feb 3, 2018

+1 lots of good work, works well for me

@secaw

This comment has been minimized.

Contributor

secaw commented Feb 3, 2018

+1 All seems to work well, I already have latest snapshots in production. An incredible amount of improvements and new features have been introduced! Special thanks to @spyhunter99 for your work and presence. Cheers.

@InI4

This comment has been minimized.

InI4 commented Feb 4, 2018

+1 can see the improvements, changes to existing code are not too many.

@cbalster

This comment has been minimized.

Contributor

cbalster commented Feb 4, 2018

All for it! +1

@MKergall

This comment has been minimized.

Collaborator

MKergall commented Feb 5, 2018

+1 !

and 100% in line with @secaw comment.

@monsieurtanuki

This comment has been minimized.

Collaborator

monsieurtanuki commented Feb 5, 2018

+1 (with a little hope that #776 is fixed - possibly by @secaw and #915)

@jmarks213

This comment has been minimized.

jmarks213 commented Feb 6, 2018

+1 In a few sparse tests 6.0 worked great for me.

@k3b

This comment has been minimized.

Contributor

k3b commented Feb 7, 2018

+-0 I am currently busy with other job. My app works stable with the old 5.x version

@miguel-porto

This comment has been minimized.

Contributor

miguel-porto commented Feb 9, 2018

Yep, +1 as there have been great improvements in the cache management (we can finally go offline for days without the panic of losing our tiles!) and in the UX in general (very smooth zoom and pan), but I think #908 should be incorporated, cause it really seems to fix the hang-on-detach bug, which is a very inconvenient bug!
BTW thank you for including me in the vote!

@Maradox

This comment has been minimized.

Collaborator

Maradox commented Feb 13, 2018

+1 I tested 6.0.0 via the OpenStreetMapViewer as well as via my own application and I didn't find any bigger problems, besides the following issues (which are minor or improvements):

  • #929 - Maybe not that important for 6.0.0
  • #928
  • #933 - PR pending
  • #926 - PR merged
@pasniak

This comment has been minimized.

Contributor

pasniak commented Feb 14, 2018

+1 I was using the map on and offline for a week or so, and haven't observed tiling hangs.

@spyhunter99

This comment has been minimized.

Collaborator

spyhunter99 commented Feb 17, 2018

thanks for the feedback everyone. I'll work as soon as I can to get the result cut. As always, please continue to report issues

spyhunter99 added a commit that referenced this issue Feb 17, 2018

spyhunter99 added a commit that referenced this issue Feb 17, 2018

#914 prepare for release, there's some issue with the owasp plugin d…
…agged in by fury, adding a temporary work around
@spyhunter99

This comment has been minimized.

Collaborator

spyhunter99 commented Feb 17, 2018

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment