New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/#1214 -General cleanup #1215

Merged
merged 6 commits into from Dec 13, 2018

Conversation

Projects
None yet
2 participants
@cbalster
Copy link
Contributor

cbalster commented Nov 28, 2018

cbalster added some commits Nov 27, 2018

android-wms cleanup
- no appcompat needed
- no robolectrix needed
- custom runner is not used
osmdroid-simple-map cleanup
- switch to appcompat
- misc cleanup
geopackage cleanup
remove unnecessary imports
OpenStreetMapViewer cleanup
- remove unnecessary imports
- remove unnecessary casts
- remove unnecessary modifiers
- remove obsolete SDK checks
- misc

@cbalster cbalster force-pushed the cbalster:bug/#1214 branch from c1b4536 to dd49575 Nov 28, 2018

btnRotateRight.setOnClickListener(this);
btnRotateLeft.setOnClickListener(this);
textViewCurrentLocation = (TextView) v.findViewById(R.id.textViewCurrentLocation);

This comment has been minimized.

@spyhunter99

spyhunter99 Dec 6, 2018

Collaborator

how does this work? Does the lack of a cast still work with previous android versions? I'm guessing it's a compile time feature

@spyhunter99 spyhunter99 merged commit fe223f1 into osmdroid:master Dec 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@cbalster cbalster deleted the cbalster:bug/#1214 branch Dec 13, 2018

@cbalster cbalster referenced this pull request Dec 18, 2018

Closed

Code Cleanup #1214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment