Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug #1299: Zoom Button Crash in 6.1.0 #1307

Merged
merged 1 commit into from Jul 20, 2019

Conversation

@shorti1996
Copy link
Contributor

commented Mar 30, 2019

Fix for #1299

fix StackOverflow, because when zooming in with zoom buttons,
osm tries to keep the map centered to the current user location.
See: org.osmdroid.views.overlay.mylocation.MyLocationNewOverlay.onSnapToItem

bug #1299: Zoom Button Crash in 6.1.0
fix StackOverflow, because when zooming in with zoom buttons,
osm tries to keep the map centered to the current user location.
See: org.osmdroid.views.overlay.mylocation.MyLocationNewOverlay.onSnapToItem
@JiKanghui

This comment has been minimized.

Copy link

commented May 30, 2019

It's finally settled. Thank you.

@InI4

This comment has been minimized.

Copy link

commented Jul 12, 2019

Just wanted to reiterate, that my app is now running 3 months on the corresponding snapshot and I have no issues at this end!

@monsieurtanuki

This comment has been minimized.

Copy link
Collaborator

commented Jul 15, 2019

Tested with the new "Snappable" dedicated demo (#1371): no more stack overflow, and a behavior that looks reasonable.

@spyhunter99 Adding the correct demo behavior to @InI4's very positive feedback, I see no reason to delay the merging of this PR as it fixes #1299. And it looks like it could be time for another version of osmdroid.

@spyhunter99 spyhunter99 merged commit 7813013 into osmdroid:master Jul 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@spyhunter99 spyhunter99 added this to the v6.1.1 milestone Jul 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.