Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feature/#1418 - custom zoom refactoring while removing the old standard zoom controllers #1419
…rd zoom controllers Impacted classes: * `AsyncTaskDemoFragment`, `CustomRecycler`, `SampleFollowMe`, `SampleHeadingCompassUp`, `SampleSplitScreen`, `WeathForceActivity`: removed a useless call to now deprecated method `MapView.setBuiltInZoomControls`, which used to be the default behavior anyway * `MapView`: removed all the references on the deprecated Android zoom controls; moved the calls to zoom control test in `dispatchTouchEvent`; deprecated method `setBuiltInZoomControls`; unrelated minor refactoring * `CustomZoomButtonsController`: made `public` method `isTouched` which uses new method `CustomZoomButtonsDisplay.isTouched`; deprecated method `onSingleTapConfirmed` and `onLongPress` * `CustomZoomButtonsDisplay`: deprecated method `isTouchedRotated` as we now check the touch event before applying the rotation; created method `isTouched(MotionEvent,boolean)` for the same reasons; unrelated minor refactoring
Works for me. I.e. I do not fully understand it, but it solves the issues solved by #1414 .
Remark: I needed to run the build with
to sidestep failing tests.
@InI4 Actually it works because it's just what you coded in #1414 ("moving the zoom ontouch detection test"), but with more impact checks and refactoring.
That being said, I've had a look at the (unrelated) crashing unit test.