Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bing map upgrade authentication and tile URL to https #1436

Merged
merged 2 commits into from Nov 16, 2019

Conversation

@jpstotz
Copy link
Contributor

jpstotz commented Nov 15, 2019

The Bing maps authentication URL that is used for sending the application's Bing Maps Key to Microsoft was still using unencrypted HTTP, instead of HTTPS.

I have verified that the URL via HTTPS works as expected, it was correctly returning a valid response using my personal Bing Maps key for the imagery-set "Road".

The Bing maps authentication URL that is used for sending the application's Bing Maps Key to Microsoft was still using unencrypted HTTP, instead of HTTPS. 

I have verified that the URL via HTTPS works as expected, it was correctly returning a valid response using my personal Bing Maps key for the imagery-set "Road".
@jpstotz

This comment has been minimized.

Copy link
Contributor Author

jpstotz commented Nov 15, 2019

All checks have failed
Looks like the osmdroid ci build system has some serious problems:

It tries to load gradle from http://services.gradle.org/distributions/gradle-2.14.1-bin.zip -> HTTP 403

The gradle project seems to disallows downloads via unprotected http (totally makes sense to me especially in the context of a ci build system). Change the URL to https:// and the download works.

@jpstotz

This comment has been minimized.

Copy link
Contributor Author

jpstotz commented Nov 15, 2019

Once my other PR #1437 has been applied the CI system will be working again and the "All checks have failed" flag should vanish.

To get the tiles via https one have to set the uriScheme to `https`. 
By doing so the received `imageUrl` will contain an https url for downloading the map tiles. 
Therefore now the metadata request and the tile download will use a TLS protected communication channel.
@jpstotz jpstotz changed the title Bing map authentication URL upgraded to https Bing map upgrade authentication and tile URL to https Nov 15, 2019
@spyhunter99 spyhunter99 merged commit 26e6090 into osmdroid:master Nov 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@spyhunter99 spyhunter99 added this to the 6.1.3 milestone Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.