New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleStyle support #614

Merged
merged 5 commits into from Feb 2, 2019

Conversation

Projects
None yet
2 participants
@Zverik
Copy link
Contributor

Zverik commented Feb 1, 2019

You can have task with big feature collections inside them: lines, polygons, markers. This PR adds a styling function, so that these features can look different, helping make sense of them.

Specification is here: https://github.com/mapbox/simplestyle-spec

Note: PR is not tested. I'd be happy if you could run it and see if it works, or wait until I manage to start the backend server.

Ilya Zverev added some commits Feb 1, 2019

Ilya Zverev
Ilya Zverev
@nrotstan

This comment has been minimized.

Copy link
Contributor

nrotstan commented Feb 1, 2019

This is a great idea, @Zverik, thank you!

@nrotstan

This comment has been minimized.

Copy link
Contributor

nrotstan commented Feb 1, 2019

@Zverik do you have a sample geojson file?

@Zverik

This comment has been minimized.

Copy link
Contributor Author

Zverik commented Feb 2, 2019

Yes, try this one: it has a few FeatureCollections for tasks, at least the first one should load fine.

Move simplestyle code to AsSimpleStyleableFeature
Extract simplestyle code from EnhancedMap into new
AsSimpleStyleableFeature interaction
@nrotstan

This comment has been minimized.

Copy link
Contributor

nrotstan commented Feb 2, 2019

I made a couple changes and have it working, @Zverik. Can you give me access to your fork so I can push to the PR?

@nrotstan nrotstan merged commit 8f9410c into osmlab:develop Feb 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Zverik

This comment has been minimized.

Copy link
Contributor Author

Zverik commented Feb 2, 2019

Thanks Neil!

@Zverik Zverik deleted the Zverik:simplestyle branch Feb 2, 2019

@nrotstan nrotstan referenced this pull request Feb 3, 2019

Merged

v3.1.3 release #617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment