Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #498 Resolved [Did Research for Hp Petrol Pump] #2369

Merged
merged 1 commit into from Mar 3, 2019

Conversation

@SahibArora
Copy link

commented Mar 2, 2019

Added Tags are:

"Emerging in - ": "United States",
"Major Country": "India",
"Their Belief": "At HPCL, we believe in the maxim: Think big, dream big and achieve big. We are the future - a future full of energy.",
"Web-SiteAddress": "http://www.hindustanpetroleum.com/LPGHome",
"What People think about it": "Took my car here for an oil change. Was everything i needed it to be. Quick, easy, cheap, they checked in on everything with y engine too an rotated my tires for free",
"brand:wikidata": "Q1619375",
"brand:wikipedia": "en:Hindustan Petroleum",

It was my first time here, please let me know, if anything could be improved.
Thank you!

Sahib

@SahibArora SahibArora changed the title Issue #498 Resolved [Did Reseacr] Issue #498 Resolved [Did Research for Hp Petrol Pump] Mar 2, 2019

@Adamant36

This comment has been minimized.

Copy link
Collaborator

commented Mar 2, 2019

Hi there. Thanks for contributing. I'm not sure what your trying to add with some of these entries, but they aren't actual tags and the index isn't for company reviews, website links, "emerging markets," the companies beliefs, or similar things anyway. So it would be good if you got rid of everything you added except the brand:wikidata and brand:wikipedia. As are those are the only usable tags in your PR. Thanks.

@bhousel bhousel merged commit 4ef1a90 into osmlab:master Mar 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bhousel

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

Thanks @SahibArora .. I ended up removing the extra tags and just merging the "HP Petrol Pump" and "Hindustan Petroleum" entries into the existing and more common "HP" entry.

Please read the contributing guide for some more details on what this project is about, and try to use only established OpenStreetMap tags in the future! 👍

@SahibArora

This comment has been minimized.

Copy link
Author

commented Mar 6, 2019

Sure, Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.