Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue 1684 #2392

Merged
merged 1 commit into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@abdiG
Copy link

commented Mar 6, 2019

added brand:wikidata and brand:wikipedia for shop/supermarket|Foodland
close 1684

@tas50

This comment has been minimized.

Copy link
Collaborator

commented Mar 6, 2019

@abdiG Looks good. In the future if you put the # sign before the issue number github will link them and then magically close it all.

@tas50 tas50 merged commit 23a3fa0 into osmlab:master Mar 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@abdiG

This comment has been minimized.

Copy link
Author

commented Mar 6, 2019

ohh ok thanks

@tas50

This comment has been minimized.

Copy link
Collaborator

commented Mar 6, 2019

I merged this before I saw the comment that @bhousel left on the issue. I'm going to add Foodland entries for the US and Australia since those exist in wikidata. There's a bit of cleanup here and in wikidata to support the various foodland stores.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.