Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wikidata and country code for Marko Aldany #2570

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@PrimeN
Copy link
Contributor

commented Apr 12, 2019

This is to close the Issue #1503

@Adamant36

This comment has been minimized.

Copy link
Collaborator

commented Apr 12, 2019

Hi there. I did a search for the Wikidata code you provided and it doesn't seem to exist. Maybe you typed it in wrong or something?

@PrimeN

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2019

It was missing a wikidata page so I went ahead and created one for it but it looks like the wikidata page is deleted. I'm not sure if I should re-create the page and update the tag again or remove the wikidata tag entirely. Please advise.

@matkoniecz

This comment has been minimized.

@matkoniecz

This comment has been minimized.

@matkoniecz

This comment has been minimized.

Copy link
Collaborator

commented May 27, 2019

After discussion with Wikidata admins I created explanation what Wikidata maintainers consider as a minimal requirements - see https://github.com/osmlab/name-suggestion-index/blob/master/CONTRIBUTING.md#adding-references-to-wikidata

Are you maybe interested in trying to create a new Wikidata entry, this time with references?

@Adamant36

This comment has been minimized.

Copy link
Collaborator

commented May 27, 2019

You don't think there would be an easier qualifying references than "has part"? That seems a little unnecessarily convoluted to me. I have yet to see it on any wikidata entries without Wikipedia articles attached to them that haven't been deleted either and I've seen a lot. So there has to be an easier reference.

@matkoniecz

This comment has been minimized.

Copy link
Collaborator

commented Jun 1, 2019

You don't think there would be an easier qualifying references than "has part"?

Can you propose something better? I would happily merge PR that would add other example or replace it with something simpler and also relatively easy to find for a typical brand entry.

@Adamant36

This comment has been minimized.

Copy link
Collaborator

commented Jun 1, 2019

Can you propose something better? I would happily merge PR that would add other example or replace it with something simpler and also relatively easy to find for a typical brand entry.

No. Not currently. Like I said on the other PR, it would be good to keep an eye out for something better though. I think ultimately it should be a general list of things that might help Wikidata entries from getting deleted. Instead of a single example. As it seems to be up to the whims of particular admins anyway. So only adding one thing might only satisfy one of them. Whereas, adding as many entries as we can seems like a much more reliable tactic. 10 bucks says another admin comes along at some point and thinks that's not an adequate reference. We should cover all our bases just in case and not rely to much on one reference. I'm pretty sure single references can be deprecated/sunseted also. I've seen it happen a few times already.

@Adamant36

This comment has been minimized.

Copy link
Collaborator

commented Jun 11, 2019

@matkoniecz any updates on this? It seems like it still doesn't have a Wikidata entry. If its not going to be restored maybe we should just create a new one.

@matkoniecz

This comment has been minimized.

Copy link
Collaborator

commented Jun 11, 2019

we should just create a new one.

to quote myself:

Are you maybe interested in trying to create a new Wikidata entry, this time with references?

And I linked https://github.com/osmlab/name-suggestion-index/blob/master/CONTRIBUTING.md#adding-references-to-wikidata

@Adamant36

This comment has been minimized.

Copy link
Collaborator

commented Jun 11, 2019

to quote myself:

Just wanted to double check. I was under the impression that they would restore them if we added the proper sources. If that's not the case, I guess we can create new entries. I worry that would be similar to edit warring or something though. Since we would be going against the wishes of the admins that there weren't Wikidata entries for these companies. Did the admins explicitly tell you we could do that?

@matkoniecz

This comment has been minimized.

Copy link
Collaborator

commented Jun 11, 2019

I was under the impression that they would restore them if we added the proper sources.

Yes, they restored bunch of them. As I explained in #2572 (comment)

For now I am waiting for someone to fix #2608 before requesting undeletion of further items.

Though note that anyone may go to Wikidata admins and ask for undeleting some items.

@matkoniecz

This comment has been minimized.

Copy link
Collaborator

commented Jun 11, 2019

Closing as it requires recreation of Wikidata entry (with references to match Wikidata requirements).

@matkoniecz matkoniecz closed this Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.