Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Brazilian Post Office #7376

Merged
merged 8 commits into from Nov 12, 2022
Merged

Improving Brazilian Post Office #7376

merged 8 commits into from Nov 12, 2022

Conversation

matheusgomesms
Copy link
Contributor

Hey guys,

I didn't have time to make suggestions to #7154, but this PR attempts to improve that PR.

Basically, due to the change of display name, things were a bit weird when editing on OSM, so I did 3 things on this PR:

Post Office

  • Added name (tag name=Correios)

Post Depot

  • Added name (tag name=Centro de Distribuição dos Correios)

Post Box

  • I created a whole new entry, given the display name of post office does not make sense here. Not sure if this part is correct, though.

What do you think? CC @vgeorge @UKChris-osm @willemarcel @LaoshuBaby

@matheusgomesms
Copy link
Contributor Author

Sorry I didn't rebase and run the build.

@vgeorge
Copy link
Contributor

vgeorge commented Nov 11, 2022

@matheusgomesms this looks good to me. 👍

@UKChris-osm
Copy link
Collaborator

I'd remove the brand if the operator data is the same, as I'd say operator trumps brand when it comes to post entries, and if the brand is the same as the operator I feel like it's just unnecessary repeat tagging.

@matheusgomesms
Copy link
Contributor Author

I'd remove the brand if the operator data is the same, as I'd say operator trumps brand when it comes to post entries, and if the brand is the same as the operator I feel like it's just unnecessary repeat tagging.

Thanks, I made those adjustments!

@UKChris-osm UKChris-osm merged commit 0623315 into osmlab:main Nov 12, 2022
@matheusgomesms matheusgomesms deleted the correios branch November 12, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants