Make stringQs ignore empty arguments

osmlab · Apr 29, 2013 · 5bf42ac · 5bf42ac
1 parent 4097799
commit 5bf42ac
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -14,7 +14,9 @@ ohauth.qsString = function(obj) {
 };
 
 ohauth.stringQs = function(str) {
-    return str.split('&').reduce(function(obj, pair){
+    return str.split('&').filter(function (pair) {
+        return pair !== '';
+    }).reduce(function(obj, pair){
         var parts = pair.split('=');
         obj[decodeURIComponent(parts[0])] = (null === parts[1]) ?
             '' : decodeURIComponent(parts[1]);

diff --git a/test/ohauth.js b/test/ohauth.js
@@ -20,6 +20,10 @@ describe('ohauth', function() {
         it('handles special characters', function() {
             expect(ohauth.stringQs('%21%27%2A%28%29=%21%27%2A%28%29')).to.eql({ "!'*()": "!'*()" });
         });
+        it('handles querystrings with empty arguments', function() {
+            expect(ohauth.stringQs('')).to.eql({});
+            expect(ohauth.stringQs('foo=1&')).to.eql({ foo: 1 });
+        });
     });
 
     describe('#nonce', function() {