{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":6985142,"defaultBranch":"master","name":"osmo-pcu","ownerLogin":"osmocom","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2012-12-03T16:08:40.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1415806?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1711394508.0","currentOid":""},"activityList":{"items":[{"before":"38bcb67ac8ba6b92b77c7abed5ebe78e0a743dd6","after":"0b0d0bbfc07ce4d4d48571b32838d975a5e53298","ref":"refs/heads/master","pushedAt":"2024-06-06T12:55:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"README.md: cosmetic: fix a typo\n\nChange-Id: Ia020f1ef3e634af1d58e0d34a92df5e827533629","shortMessageHtmlLink":"README.md: cosmetic: fix a typo"}},{"before":"4f4f44f0bcba3996578d4b8a8fd714872de78447","after":"38bcb67ac8ba6b92b77c7abed5ebe78e0a743dd6","ref":"refs/heads/master","pushedAt":"2024-05-16T05:48:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"contrib/systemd: run as osmocom user\n\nI have verified that with AmbientCapabilities=CAP_SYS_NICE, setting\nscheduling policy as described in the manual still works as expected.\n\nRelated: OS#4107\nChange-Id: I362a9e55309033c42b16f12321f8d1aa27da7b59","shortMessageHtmlLink":"contrib/systemd: run as osmocom user"}},{"before":"75727403bf2184dd045c1867a7493e9b6a57d320","after":"4f4f44f0bcba3996578d4b8a8fd714872de78447","ref":"refs/heads/master","pushedAt":"2024-05-10T07:53:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"contrib: remove rpm spec file\n\nRelated: https://osmocom.org/news/255\nRelated: OS#6446\nChange-Id: Ibc5a8ddd74d2a1b2da4c514260c8c506c10613e8","shortMessageHtmlLink":"contrib: remove rpm spec file"}},{"before":"f0a654cc46e4d6f687cafed00a6079dc44e21e19","after":"75727403bf2184dd045c1867a7493e9b6a57d320","ref":"refs/heads/master","pushedAt":"2024-04-15T08:56:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"doc: Introduce code architecture section with main class diagram\n\nThis is useful to understand the data model in a quick gasp.\n\nChange-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d","shortMessageHtmlLink":"doc: Introduce code architecture section with main class diagram"}},{"before":"d76e3a34276e823326c65988948052c2b15be8fd","after":"f0a654cc46e4d6f687cafed00a6079dc44e21e19","ref":"refs/heads/master","pushedAt":"2024-04-12T19:54:54.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"tbf_ul.h: Mark empty param list as void\n\nWhile at it, fix wrong whitespace indentation in one of the lines.\n\nChange-Id: I2a9213a9fdbe0f4b70d820c449dbb71539a733ce","shortMessageHtmlLink":"tbf_ul.h: Mark empty param list as void"}},{"before":"abc1b19bbfb5e3e9deb083e5270fb91eee39a188","after":"75727403bf2184dd045c1867a7493e9b6a57d320","ref":"refs/heads/pespin/fix","pushedAt":"2024-04-12T19:53:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"doc: Introduce code architecture section with main class diagram\n\nThis is useful to understand the data model in a quick gasp.\n\nChange-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d","shortMessageHtmlLink":"doc: Introduce code architecture section with main class diagram"}},{"before":"d76e3a34276e823326c65988948052c2b15be8fd","after":"abc1b19bbfb5e3e9deb083e5270fb91eee39a188","ref":"refs/heads/pespin/fix","pushedAt":"2024-04-12T15:57:39.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"doc: Introduce code architecture section with main class diagram\n\nThis is useful to understand the data model in a quick gasp.\n\nChange-Id: Ibf6dd6f7e4d6370ad40733820faa70f9e5bc0e7d","shortMessageHtmlLink":"doc: Introduce code architecture section with main class diagram"}},{"before":"5eb7699b6d6fa5a9c79c75bd8119012585676416","after":"d76e3a34276e823326c65988948052c2b15be8fd","ref":"refs/heads/master","pushedAt":"2024-03-26T09:23:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"Make sure GprsMs free() also frees its tbfs\n\nThis fixes TBF objects leaking and ending up alive when the MS object is\nexplicitly freed through talloc_free (and sporadically\ncrashing TbfTest once a timeout for them occur).\n\nThis mostly affects unit tests, where most of the explicit free()\nhappens.\nIn osmo-pcu, in general, the GprsMs object only gets _free() called when\nits resource count reaches 0, aka no more TBFs are attached to it. Hence\nin general GprsMs object is freed() only when no TBFs (to be leaked) are\npresent.\nHowever, in the unit tests it's usual that we want to wipe the entire\ncontext by eg. feeing the PCU, the BTS or MS object, which should also\nfree the related TBFs.\n\nWhen running osmo-pcu this may only be an issue when the MS object is\nfreed explicitly, which could happen for instance when a BTS is torn down,\nie. PCUIF going down, moment at which all GprsMs of that BTS are freed.\nBut in there actually it iterates over PDCHs to free all TBFs, so it's\nfine.\nIf we iterated over MS, this could have ended up in a crash, like\nit happened in TbfTest sporadically, but it's not a bit problem if we\ncrash + restart at that time since anyway the BTS is gone ore just\ngetting up around that time.\n\nRelated: OS#6359\nChange-Id: Ibbdec94acb8132be20508d3178d88da44bfaf91d","shortMessageHtmlLink":"Make sure GprsMs free() also frees its tbfs"}},{"before":"2262916e0c9422f93315044a47382aadbce31402","after":"5eb7699b6d6fa5a9c79c75bd8119012585676416","ref":"refs/heads/master","pushedAt":"2024-03-25T22:41:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"cosmetic: TbfTest: fix typo in comment\n\nChange-Id: I35bb28c5669747823b0dfebe27ecd7a5a0c5d60f","shortMessageHtmlLink":"cosmetic: TbfTest: fix typo in comment"}},{"before":"61025bbf7d61b3005b476afb6348fb605263d649","after":"d76e3a34276e823326c65988948052c2b15be8fd","ref":"refs/heads/pespin/fix","pushedAt":"2024-03-25T20:11:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"Make sure GprsMs free() also frees its tbfs\n\nThis fixes TBF objects leaking and ending up alive when the MS object is\nexplicitly freed through talloc_free (and sporadically\ncrashing TbfTest once a timeout for them occur).\n\nThis mostly affects unit tests, where most of the explicit free()\nhappens.\nIn osmo-pcu, in general, the GprsMs object only gets _free() called when\nits resource count reaches 0, aka no more TBFs are attached to it. Hence\nin general GprsMs object is freed() only when no TBFs (to be leaked) are\npresent.\nHowever, in the unit tests it's usual that we want to wipe the entire\ncontext by eg. feeing the PCU, the BTS or MS object, which should also\nfree the related TBFs.\n\nWhen running osmo-pcu this may only be an issue when the MS object is\nfreed explicitly, which could happen for instance when a BTS is torn down,\nie. PCUIF going down, moment at which all GprsMs of that BTS are freed.\nBut in there actually it iterates over PDCHs to free all TBFs, so it's\nfine.\nIf we iterated over MS, this could have ended up in a crash, like\nit happened in TbfTest sporadically, but it's not a bit problem if we\ncrash + restart at that time since anyway the BTS is gone ore just\ngetting up around that time.\n\nRelated: OS#6359\nChange-Id: Ibbdec94acb8132be20508d3178d88da44bfaf91d","shortMessageHtmlLink":"Make sure GprsMs free() also frees its tbfs"}},{"before":"06a949926df1b261f71ce6b773eaebf053dd366b","after":"61025bbf7d61b3005b476afb6348fb605263d649","ref":"refs/heads/pespin/fix","pushedAt":"2024-03-25T20:08:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"Make sure GprsMs free() also frees its tbfs\n\nThis fixes TBF objects leaking and ending up alive when the MS object is\nexplicitly freed through talloc_free (and sporadically\ncrashing TbfTest once a timeout for them occur).\n\nThis mostly affects unit tests, where most of the explicit free()\nhappens.\nIn osmo-pcu, in general, the GprsMs object only gets _free() called when\nits resource count reaches 0, aka no more TBFs are attached to it. Hence\nin general GprsMs object is freed() only when no TBFs (to be leaked) are\npresent.\nHowever, in the unit tests it's usual that we want to wipe the entire\ncontext by eg. feeing the PCU, the BTS or MS object, which should also\nfree the related TBFs.\n\nWhen running osmo-pcu this may only be an issue when the MS object is\nfreed explicitly, which could happen for instance when a BTS is torn down,\nie. PCUIF going down, moment at which all GprsMs of that BTS are freed.\nBut in there actually it iterates over PDCHs to free all TBFs, so it's\nfine.\nIf we iterated over MS, this could have ended up in a crash, like\nit happened in TbfTest sporadically, but it's not a bit problem if we\ncrash + restart at that time since anyway the BTS is gone ore just\ngetting up around that time.\n\nRelated: OS#6359\nChange-Id: I779cd94a9f6885186b9e022a1c0d5238a2f25392","shortMessageHtmlLink":"Make sure GprsMs free() also frees its tbfs"}},{"before":null,"after":"06a949926df1b261f71ce6b773eaebf053dd366b","ref":"refs/heads/pespin/fix","pushedAt":"2024-03-25T19:21:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"Force free of tbfs upon GprsMs object free()\n\nChange-Id: Ibbdec94acb8132be20508d3178d88da44bfaf91d","shortMessageHtmlLink":"Force free of tbfs upon GprsMs object free()"}},{"before":"874aac595300c6d9ee32053ef8b5f4f9b784c471","after":"2262916e0c9422f93315044a47382aadbce31402","ref":"refs/heads/master","pushedAt":"2024-03-19T13:27:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"doc: Mention the `gb-dialect` vty option, as it is quite essential\n\nWe should have introduced this documentation snipped years ago, when\nfirst introducing IP-SNS support in libosmogb/osmo-pcu.\n\nChange-Id: I83709b7231c2a3930e1b3f09b737319fb7d7e741","shortMessageHtmlLink":"doc: Mention the <code>gb-dialect</code> vty option, as it is quite essential"}},{"before":"0f0cc4477c8686b034fd959cb90c892c06ffd77d","after":"874aac595300c6d9ee32053ef8b5f4f9b784c471","ref":"refs/heads/master","pushedAt":"2024-02-19T20:47:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"fix license headers\n\nI'm not sure why some files did contain an AGPLv3+ header, instead of\nthe GPLv2+ which is the actual overall project license.  I consider it a\nmistake.\n\nIn any case, any copyrightable contribution to those files was done by\nsysmocom employees, so I as managing directory can legally make a\nlicense change, whther or not it was a mistake early on or not.\n\nThe only  remaining AGPLv3+ files are those implementing the \"direct\nPHY\" interface for osmo-bts-{symo,lc15,oc2g}.  That is als\nunintentional, but more complex to resolve as they were copied from\nosmo-bts, which is indeed an AGPLv3+ project.\n\nChange-Id: I52533193de0ec7e24bf7c5bb035589ba5b9419e4","shortMessageHtmlLink":"fix license headers"}},{"before":"b04e1d7d0ce1ca95a0c7e9835478eb751bd47669","after":"0f0cc4477c8686b034fd959cb90c892c06ffd77d","ref":"refs/heads/master","pushedAt":"2024-02-13T13:51:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"tbf_ul_fsm: Fix wrong cast\n\nChange-Id: I6c68e85cfa7ca8d08ed7c851e31831c30772012e","shortMessageHtmlLink":"tbf_ul_fsm: Fix wrong cast"}},{"before":"41bb800e3e83982b839f00ecfa29b0a40e2f1d93","after":"b04e1d7d0ce1ca95a0c7e9835478eb751bd47669","ref":"refs/heads/master","pushedAt":"2023-12-14T16:40:41.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"Revert \"Revert \"pdch_ul_controller: migrate from fn_cmp() to gsm0502_fncmp()\"\"\n\nNow that 1.4.0 is released, bring back the patch that was temporarily\nreverted to avoid the need for a new libosmocore.\n\nThis reverts commit 16729ba72761fc981bcec6d3747d6f7dab4413ca.\n\nChange-Id: Idd113e328a693df2e8f2f5d172eaf5bf2bfcf009","shortMessageHtmlLink":"Revert \"Revert \"pdch_ul_controller: migrate from fn_cmp() to gsm0502_…"}},{"before":"9658f0221479a2a427dd190a5db45a4d202e090c","after":null,"ref":"refs/heads/osmith/1.4.0","pushedAt":"2023-12-11T13:44:16.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"}},{"before":"9658f0221479a2a427dd190a5db45a4d202e090c","after":null,"ref":"refs/heads/osmith/1.3.2","pushedAt":"2023-12-11T13:44:16.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"}},{"before":null,"after":"9658f0221479a2a427dd190a5db45a4d202e090c","ref":"refs/heads/osmith/1.4.0","pushedAt":"2023-12-11T10:18:12.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"Bump version: 1.3.0.1-09dc → 1.3.1\n\nChange-Id: I7fe48ac3176f9d48660260fb268ee22eedc78d1a","shortMessageHtmlLink":"Bump version: 1.3.0.1-09dc → 1.3.1"}},{"before":null,"after":"9658f0221479a2a427dd190a5db45a4d202e090c","ref":"refs/heads/osmith/1.3.2","pushedAt":"2023-12-11T09:57:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"Bump version: 1.3.0.1-09dc → 1.3.1\n\nChange-Id: I7fe48ac3176f9d48660260fb268ee22eedc78d1a","shortMessageHtmlLink":"Bump version: 1.3.0.1-09dc → 1.3.1"}},{"before":null,"after":"8b8bb2ff8e46080db0c7093103490d605c2ff851","ref":"refs/heads/osmith/wip","pushedAt":"2023-12-11T09:45:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"gprs_rlcmac_sched: fix condition for generating dummy blocks on idle\n\nWhen a PDCH is idle, then the gaps are filled with dummy blocks. OsmoPCU\nsupports generating the dummy blocks locally, so that a continous stream of\nPDCH blocks is sent to L1. However, some BTS models (the OsmoTRX based models\nin particular) are able to generate the idle blocks locally. In this case the\nPCU should leave the genration of the dummy blocks to the BTS in order to\nsave processing time and load on the PCUIF interface.\n\nIn gprs_rlcmac_sched we already have a flag to skip idle frames in case we do\nnot use the so called \"direct phy access\". A similar mechanism also exists in\npcu_l1_if.cpp in function pcu_rx_rts_req_ptcch().\n\nUnfortunately this check is not implemented correctly. The flag gets set when\nthe ENABLE_DIRECT_PHY define constant is set. However, this does not say\nanything about whether the BTS model supports the generation of idle blocks or\nnot. The define constant is intended to be used to disable direct phy related\ncode in on platforms where no direct phy code is used or cannot be used. We\nmust instead check the BTS model (bts->bts_model) in order to decide whether\nthis particular BTS type requires the generation of dummy blocks or not.\n\nRelated: OS#6191\nChange-Id: I7a08d8cc670fa14f7206ffffdbc22351f3668a17\n(cherry picked from commit 469584f136061261bb7b05006d674aca42e3b150)","shortMessageHtmlLink":"gprs_rlcmac_sched: fix condition for generating dummy blocks on idle"}},{"before":"13fa09d46d3f6f74ae0108e8a6121eb674099093","after":"41bb800e3e83982b839f00ecfa29b0a40e2f1d93","ref":"refs/heads/master","pushedAt":"2023-12-05T17:03:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"bts: rename struct member gen_idle_blocks to gen_idle_blocks_C0\n\nThe struct member gen_idle_blocks controls whether the the PCU has to\ngenerate dummy blocks to fill idle periods or if this task is left to\nthe BTS hardware.\n\nSince idle dummy blocks only have to be transmitted on the C0 carrier,\nwe should rename the gen_idle_blocks struct member to\ngen_idle_blocks_C0.\n\nRelated: OS#6198\nChange-Id: If9511ed911f9c5d6d463881a387a9e7d11a15465","shortMessageHtmlLink":"bts: rename struct member gen_idle_blocks to gen_idle_blocks_C0"}},{"before":"469584f136061261bb7b05006d674aca42e3b150","after":"13fa09d46d3f6f74ae0108e8a6121eb674099093","ref":"refs/heads/master","pushedAt":"2023-12-03T02:08:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"Use uniform log format for default config files\n\nRelated: OS#6272\nChange-Id: I0d0042aa37da887afa0e9a5060cfbacaec23ed0a","shortMessageHtmlLink":"Use uniform log format for default config files"}},{"before":"26dca56db7302a31e1710d364abf515a8af250f2","after":"469584f136061261bb7b05006d674aca42e3b150","ref":"refs/heads/master","pushedAt":"2023-11-25T15:17:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"gprs_rlcmac_sched: fix condition for generating dummy blocks on idle\n\nWhen a PDCH is idle, then the gaps are filled with dummy blocks. OsmoPCU\nsupports generating the dummy blocks locally, so that a continous stream of\nPDCH blocks is sent to L1. However, some BTS models (the OsmoTRX based models\nin particular) are able to generate the idle blocks locally. In this case the\nPCU should leave the genration of the dummy blocks to the BTS in order to\nsave processing time and load on the PCUIF interface.\n\nIn gprs_rlcmac_sched we already have a flag to skip idle frames in case we do\nnot use the so called \"direct phy access\". A similar mechanism also exists in\npcu_l1_if.cpp in function pcu_rx_rts_req_ptcch().\n\nUnfortunately this check is not implemented correctly. The flag gets set when\nthe ENABLE_DIRECT_PHY define constant is set. However, this does not say\nanything about whether the BTS model supports the generation of idle blocks or\nnot. The define constant is intended to be used to disable direct phy related\ncode in on platforms where no direct phy code is used or cannot be used. We\nmust instead check the BTS model (bts->bts_model) in order to decide whether\nthis particular BTS type requires the generation of dummy blocks or not.\n\nRelated: OS#6191\nChange-Id: I7a08d8cc670fa14f7206ffffdbc22351f3668a17","shortMessageHtmlLink":"gprs_rlcmac_sched: fix condition for generating dummy blocks on idle"}},{"before":"c25f4fb9c99357ea40bff907e1de7ddea77e0784","after":"26dca56db7302a31e1710d364abf515a8af250f2","ref":"refs/heads/master","pushedAt":"2023-11-21T09:17:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"pcu_l1_if: signal BTS model via PCUIF\n\nAt the moment the PCU has no way of knowing with which BTS model it is\nused with. However, some BTS models may require slightly different\nbehaviour by the PCU, depending on which BTS model is used. So, lets add\nan additional bts_model field to struct gsm_pcu_if_info_ind in order to\nconvey the exact BTS model to the PCU and store this information in\nstruct gprs_rlcmac_bts\n\nRelated: OS#6191\nChange-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047","shortMessageHtmlLink":"pcu_l1_if: signal BTS model via PCUIF"}},{"before":"46140948d9800bca6a7b4299f08b25efc1af0fa3","after":"c25f4fb9c99357ea40bff907e1de7ddea77e0784","ref":"refs/heads/master","pushedAt":"2023-11-12T19:18:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"TBF status: Fix VTY output text\n\nThe vty command 'show bts pdch' had the UL and DL TBF count reversed.\nThis patch corrects that.\n\nChange-Id: Ic906ca9d02811cb96e4530af43fbc3769f6afce7","shortMessageHtmlLink":"TBF status: Fix VTY output text"}},{"before":null,"after":"070b7b2fc57fdb30adab4d0789acfdf155c426e9","ref":"refs/heads/pmaier/pcuif","pushedAt":"2023-11-10T09:50:09.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"pcu_l1_if: signal BTS model via PCUIF\n\nAt the moment the PCU has no way of knowing with which BTS model it is\nused with. However, some BTS models may require slightly different\nbehaviour by the PCU, depending on which BTS model is used. So, lets add\nan additional bts_model field to struct gsm_pcu_if_info_ind in order to\nconvey the exact BTS model to the PCU and store this information in\nstruct gprs_rlcmac_bts\n\nRelated: OS#6191\nChange-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047","shortMessageHtmlLink":"pcu_l1_if: signal BTS model via PCUIF"}},{"before":"952f5c7b9566aff2322fb226d23103bd503fa152","after":"46140948d9800bca6a7b4299f08b25efc1af0fa3","ref":"refs/heads/master","pushedAt":"2023-10-24T15:10:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"pcuif_proto: drop support for PCUIF v10\n\nWe now use PCUIF v11 in the TTCN3 tests exclusively and also osmo-bts\nand osmo-bsc only support PCUIF v11. There is no longer a need to\nmaintain a backward compatibility to PCUIF v10 in osmo-pcu.\n\nRelated: OS#5927\nChange-Id: I68a3f59d5c960ae3a4fbd74f9d4a894295cb9ed8","shortMessageHtmlLink":"pcuif_proto: drop support for PCUIF v10"}},{"before":null,"after":"ea58a2bd16456207c90e65eb4c578b42faa5d299","ref":"refs/heads/pmaier/pcuiftest","pushedAt":"2023-10-10T12:06:16.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"pcuif_proto: drop support for PCUIF v10\n\nWe now use PCUIF v11 in the TTCN3 tests exclusively and also osmo-bts\nand osmo-bsc only support PCUIF v11. There is no longer a need to\nmaintain a backward compatibility to PCUIF v10 in osmo-pcu.\n\nRelated: OS#5927\nChange-Id: I68a3f59d5c960ae3a4fbd74f9d4a894295cb9ed8","shortMessageHtmlLink":"pcuif_proto: drop support for PCUIF v10"}},{"before":"8caa915c46f68368caed576e8a799e033293a938","after":"952f5c7b9566aff2322fb226d23103bd503fa152","ref":"refs/heads/master","pushedAt":"2023-10-09T11:40:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"osmocom-gerrit","name":"Osmocom Gerrit Code Review","path":"/osmocom-gerrit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/32628598?s=80&v=4"},"commit":{"message":"Increase RR scheduler priority to 20, to avoid dropped bursts\n\nThis has been fixed in osmo-bts too.\n\nIf frames are not deliverd fast enough to the DSP, bursts will get\ndropped. The osmo-bts-sysmo process must have priority over other\nprocesses, so it can deliver frames fast enough.\n\nRelated: OS#6199\nChange-Id: Ifa2c36bc0975e89d21b6fb2fc49db6077e5207da","shortMessageHtmlLink":"Increase RR scheduler priority to 20, to avoid dropped bursts"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEXjD5BwA","startCursor":null,"endCursor":null}},"title":"Activity · osmocom/osmo-pcu"}