feat: implement pool liquidity query in pool manager, deprecate the one in gamm #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:x/gamm
stackman27
requested review from
czarcas7ic,
p0mvn and
mattverse
as code owners
mattverse
reviewed
Apr 20, 2023
p0mvn
approved these changes
Apr 21, 2023
|
@p0mvn @mattverse imported tests and readded cli! |
p0mvn
requested changes
Apr 24, 2023
x/poolmanager/router_test.go
Outdated
Comment on lines
2049
to
2050
| // Create default CL pool | ||
| pool := s.PrepareConcentratedPool() |
There was a problem hiding this comment.
Please also add a test with non-cl pool e.g. balancer
There was a problem hiding this comment.
added default balancer asset check. let me know if that suffice
x/poolmanager/router_test.go
Outdated
Comment on lines
2011
to
2036
| name: "valid with 2 coins", | ||
| poolId: 1, | ||
| poolLiquidity: defaultCoins, | ||
| expectedResult: defaultCoins, | ||
| }, | ||
| { | ||
| name: "valid with 1 coin", | ||
| poolId: 1, | ||
| poolLiquidity: sdk.NewCoins(defaultPoolCoinTwo), | ||
| expectedResult: sdk.NewCoins(defaultPoolCoinTwo), | ||
| }, | ||
| { | ||
| // can only happen if someone sends extra tokens to pool | ||
| // address. Should not occur in practice. | ||
| name: "valid with 3 coins", | ||
| poolId: 1, | ||
| poolLiquidity: sdk.NewCoins(defaultPoolCoinTwo, defaultPoolCoinOne, nonPoolCool), | ||
| expectedResult: defaultCoins, | ||
| }, | ||
| { | ||
| // this can happen if someone sends random dust to pool address. | ||
| name: "only non-pool coin - does not show up in result", | ||
| poolId: 1, | ||
| poolLiquidity: sdk.NewCoins(nonPoolCool), | ||
| expectedResult: sdk.Coins(nil), | ||
| }, |
There was a problem hiding this comment.
Some of these tests are only relevant in the context of concentrated liquidity (looks like this is where they were copied from).
What makes sense to be tested here:
- can route to CL module and get liquidity
- can route to gamm module and get liquidity
- some error cases specific to poolmanager
Please refactor the tests to be relevant for this level of abstraction
stackman27
force-pushed
the
sis/01-pool-liq-query
branch
from
e678d3d
to
df04795
Compare
stackman27
force-pushed
the
sis/01-pool-liq-query
branch
from
aa3766d
to
23f4952
Compare
p0mvn
approved these changes
Apr 25, 2023
|
Merging since all earlier comments have been addressed |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4802
What is the purpose of the change
Implement total pool liquidity for frontends in pool manager. Deprecate the one in gamm and make it route through pool manager.
Brief Changelog
Testing and Verifying
tested using localosmosis with state
output;
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)