Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove linear # of bech32 encodes introduced #505

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

ValarDragon
Copy link
Member

Removes computational overhead introduced in #501, for fixing printed format of bech32 addresses

@codecov-commenter
Copy link

Codecov Report

Merging #505 (f4e63d6) into main (1bd2e71) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #505   +/-   ##
=======================================
  Coverage   20.47%   20.47%           
=======================================
  Files         163      163           
  Lines       23177    23179    +2     
=======================================
+ Hits         4745     4747    +2     
  Misses      17671    17671           
  Partials      761      761           
Impacted Files Coverage Δ
x/incentives/keeper/gauge.go 62.67% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bd2e71...f4e63d6. Read the comment docs.

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a way more intuitive way to have the bech32addr while reducing computation! Nice!

@ValarDragon ValarDragon merged commit 067c05a into main Oct 6, 2021
@ValarDragon ValarDragon deleted the dev/remove_linear_bech32_encodes branch October 6, 2021 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants