We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This is the patch I used to get TabFS functioning with Brave:
- ( "$1" == "chromium" && "$#" -eq 2 && ${#2} -eq 32 ) ) ) ]]; then - echo "Usage: $0 <chrome EXTENSION_ID | chromium EXTENSION_ID | firefox>" + ( "$1" == "chromium" && "$#" -eq 2 && ${#2} -eq 32 ) || + ( "$1" == "brave" && "$#" -eq 2 && ${#2} -eq 32 ) ) ) ]]; then + echo "Usage: $0 <chrome EXTENSION_ID | chromium EXTENSION_ID | brave EXTENSION_ID | firefox>" exit 2 fi @@ -32,6 +33,8 @@ MANIFEST_LOCATION="$HOME/Library/Application Support/Google/Chrome/NativeMessagingHosts";; "Darwin chromium") MANIFEST_LOCATION="$HOME/Library/Application Support/Chromium/NativeMessagingHosts";; + "Darwin brave") + MANIFEST_LOCATION="$HOME/Library/Application Support/Google/Chrome/NativeMessagingHosts";; esac
As you can see Brave installs to the same place as normal Chrome, instead of its own Brave-Browser/NativeMessagingHosts.
I think it would be helpful to update your documentation site to note that Brave users should use the chrome option.
Citation: https://support.1password.com/could-not-connect/
The text was updated successfully, but these errors were encountered:
I almost submitted a pull request to add a mkdir -p for MANIFEST_LOCATION, but the code already has that– so this would work.
mkdir -p
Sorry, something went wrong.
f47c7f0
No branches or pull requests
This is the patch I used to get TabFS functioning with Brave:
As you can see Brave installs to the same place as normal Chrome, instead of its own Brave-Browser/NativeMessagingHosts.
I think it would be helpful to update your documentation site to note that Brave users should use the chrome option.
Citation: https://support.1password.com/could-not-connect/
The text was updated successfully, but these errors were encountered: