support add the version in InternalExtensionInfo #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cssmason
changed the title
cssmason
changed the title
cssmason
changed the title
zwass
reviewed
Apr 4, 2022
| @@ -80,7 +81,7 @@ func ServerPingInterval(interval time.Duration) ServerOption { | |||
| // communicating with osquery over the socket at the provided path. If | |||
| // resolving the address or connecting to the socket fails, this function will | |||
| // error. | |||
| func NewExtensionManagerServer(name string, sockPath string, opts ...ServerOption) (*ExtensionManagerServer, error) { | |||
| func NewExtensionManagerServer(name string, version string, sockPath string, opts ...ServerOption) (*ExtensionManagerServer, error) { | |||
There was a problem hiding this comment.
Instead of making version a required parameter (which would be a breaking API change), can you make a ServerOption that allows setting the version?
zwass
requested changes
Apr 5, 2022
|
Looks to be closed in favor of #97 🤷 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.