Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnable Control Flow Guard on Windows #2986
Merged
Conversation
|
So if this is passing our compile and unit tests, does that meaning we're also passing the CFI checks? And if this is enabled for the default compile/link, are we adding any additional overhead? If so, could we gate this to debug builds? |
|
NB: I'm 100% OK with this being enabled for all runtime binaries if it makes them safer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This adds the compiler and linker flags necessary to enable control flow guard on the Windows build of osquery.