Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Firehose/Kinesis support to Windows #3641
Merged
Conversation
…etails). The Aws::Auth::InstanceProfileCredentialsProvider provider causes a crash when used. I have decided to disable it when compiling on Windows.
|
A couple of smaller nits, then I think we're good to fold this in, thanks! |
| @@ -29,6 +29,22 @@ static const char* kAwsProfileFileEnvVar = "AWS_SHARED_CREDENTIALS_FILE"; | |||
| static const char* kAwsAccessKeyEnvVar = "AWS_ACCESS_KEY_ID"; | |||
| static const char* kAwsSecretKeyEnvVar = "AWS_SECRET_ACCESS_KEY"; | |||
|
|
|||
| void SetEnvVar(const std::string& name, const std::string& value) { | |||
muffins
Sep 3, 2017
Contributor
Is it possibly to use the abstractions we already have over set/unset env vars? https://github.com/facebook/osquery/blob/f9cb7149a9ac53c4aa563886d3bd37955876753f/osquery/core/process.h#L224
Is it possibly to use the abstractions we already have over set/unset env vars? https://github.com/facebook/osquery/blob/f9cb7149a9ac53c4aa563886d3bd37955876753f/osquery/core/process.h#L224
| @@ -64,6 +80,9 @@ TEST_F(AwsUtilTests, test_get_credentials) { | |||
| ASSERT_EQ("FLAG_ACCESS_KEY_ID", credentials.GetAWSAccessKeyId()); | |||
| ASSERT_EQ("flag_secret_key", credentials.GetAWSSecretKey()); | |||
|
|
|||
| // Profiles are not working on Windows; see the constructor of | |||
| // OsqueryAWSCredentialsProviderChain for more information | |||
| #if !defined(WINDOWS) | |||
muffins
Sep 3, 2017
Contributor
If these aren't failing to compile, would you mind prefering the use of if (isPlatform(PlatformType::TYPE_WINDOWS)) { instead of preprocessor #defines?
If these aren't failing to compile, would you mind prefering the use of if (isPlatform(PlatformType::TYPE_WINDOWS)) { instead of preprocessor #defines?
| $version = '1.0.107' | ||
| $chocoVersion = '1.0.107-r1' | ||
| $version = '1.1.44' | ||
| $chocoVersion = '1.1.44-r1' |
muffins
Sep 3, 2017
Contributor
If this is the first time we've seen this version, the -r1 isn't required and we can do whole version releases, mind removing this?
If this is the first time we've seen this version, the -r1 isn't required and we can do whole version releases, mind removing this?
| $packageName = 'aws-sdk-cpp' | ||
| $projectSource = 'https://github.com/aws/aws-sdk-cpp' | ||
| $packageSourceUrl = 'https://github.com/apache/thrift' | ||
| $packageSourceUrl = 'https://github.com/aws/aws-sdk-cpp/archive/$version.zip' |
muffins
Sep 3, 2017
Contributor
Thank you :)
Thank you :)
Changes in the test module: o Use the setEnvVar/unsetEnvVar wrappers. o Do not use the preprocessor to disable test parts that are not compatible with Windows. o Fix the nupkg package version (remove the '-r1' suffix).
|
@alessandrogario updated the pull request - view changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
List of changes
Notes
The Aws::Auth::InstanceProfileCredentialsProvider causes a crash when enabled on Windows. I have disabled it for now, and would like to have some feedback.