Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Azure Pipelines build and test jobs #5610

Merged
merged 1 commit into from Jun 28, 2019

Conversation

@Smjert
Copy link
Contributor

@Smjert Smjert commented Jun 28, 2019

Originally the separation existed because there were multiple branches,
and only one of them was protected by PRs.
So broken commits could land and differentiating from broken build
or tests was useful.

This is not true anymore and PRs checks are per pipeline, not per job,
so the separation wouldn't make a difference.

Originally the separation existed because there were multiple branches,
and only one of them was protected by PRs.
So broken commits could land and differentiating from broken build
or tests was useful.

This is not true anymore and PRs checks are per pipeline, not per job,
so the separation wouldn't make a difference.
Copy link
Member

@theopolis theopolis left a comment

Please squash-merge when you are ready. Thanks!

@Smjert Smjert merged commit 2addb87 into osquery:master Jun 28, 2019
1 of 2 checks passed
1 of 2 checks passed
osquery #20190628.1 failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Smjert Smjert deleted the Smjert:stefano/ci/merge-jobs branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.