Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
windows/certificates: Improve table completeness for Personal certificates for system accounts #5696
Small follow up to #5640.
When proactively searching disk for personal certificates, there is no
This now makes the table even more complete; any certificates found in
This is what it looked like previously. This is on a system where there are no store locations other than Users that have a system store string like the above two. However, there is a certificate installed into the Local System certificate directory.
When proactively searching disk for personal certificates, there is no need to filter system accounts (SYSTEM, Local Service, etc) anymore because `findUserPersonalCertsOnDisk` is now capable of handling those accounts by dynamically finding a user's home dir (as rather than constructing a hard coded path). This now makes the table even more complete; any certificates found in the system accounts directories will always be found. Previously they could be found but only if there was a store location other than the `Users` store location that had a system store string that looked like `S-1-5-18\My` or `.DEFAULT\My`.