Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upwindows/certificates: Fix bug in environment variable expansion #5697
Conversation
|
Maybe @muffins or @theopolis could look? Sorry for all the follow-ons |
I observed rare cases where it would just write 1 wchar_t and return. Add a loop that repeatedly retries up to 100 times before returning failure to the caller.
offlinemark
force-pushed the
trailofbits:mark/fix/win-certs-env-expand
branch
from
5ae7cdd
to
24f6032
offlinemark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is a followup to #5640. This should be the last one :)
This fixes a bug in environment variable expansion that occurs when paths to Personal certificate directories are constructed for system accounts.