Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows/certificates: Fix bug in environment variable expansion #5697

Merged
merged 4 commits into from Aug 13, 2019

Conversation

@mossberg
Copy link
Contributor

commented Aug 8, 2019

This is a followup to #5640. This should be the last one :)

This fixes a bug in environment variable expansion that occurs when paths to Personal certificate directories are constructed for system accounts.

@communitybridge-easycla

This comment has been minimized.

Copy link

commented Aug 8, 2019

CLA Check
The committers are authorized under a signed CLA.

@mossberg

This comment has been minimized.

Copy link
Contributor Author

commented Aug 8, 2019

Maybe @muffins or @theopolis could look? Sorry for all the follow-ons 😅 This should be the last one.

Copy link
Contributor

left a comment

Mark Mossberg added 4 commits Aug 7, 2019
I observed rare cases where it would just write 1 wchar_t and return.
Add a loop that repeatedly retries up to 100 times before returning
failure to the caller.
@mossberg mossberg force-pushed the trailofbits:mark/fix/win-certs-env-expand branch from 5ae7cdd to 24f6032 Aug 9, 2019
@mossberg mossberg changed the title windows/certificates: Correctly handle incomplete writes from ExpandEnvironmentStringsW windows/certificates: Fix bug in environment variable expansion Aug 9, 2019
@theopolis theopolis merged commit c3b3476 into osquery:master Aug 13, 2019
13 checks passed
13 checks passed
Mark Mossberg Thank you for signing the CLA.
Details
osquery Build #20190809.1 succeeded
Details
osquery (Linux) Linux succeeded
Details
osquery (LinuxBuck Release) LinuxBuck Release succeeded
Details
osquery (LinuxCMake Debug) LinuxCMake Debug succeeded
Details
osquery (LinuxCMake Release) LinuxCMake Release succeeded
Details
osquery (Windows) Windows succeeded
Details
osquery (WindowsBuck Release) WindowsBuck Release succeeded
Details
osquery (WindowsCMake Release) WindowsCMake Release succeeded
Details
osquery (macOS) macOS succeeded
Details
osquery (macOSBuck Release) macOSBuck Release succeeded
Details
osquery (macOSCMake Debug) macOSCMake Debug succeeded
Details
osquery (macOSCMake Release) macOSCMake Release succeeded
Details
@mossberg mossberg deleted the trailofbits:mark/fix/win-certs-env-expand branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.