Fix mem leak regression with Windows' sids API #6984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-myers-tob
changed the title
mike-myers-tob
changed the title
theopolis
approved these changes
Mar 3, 2021
Check out the example here, https://github.com/osquery/osquery/blob/master/osquery/tables/system/darwin/mdls.mm#L70 and see if that approach would be workable here. |
|
Great idea @theopolis! I'm a huge fan of |
aikuchin
pushed a commit
to aikuchin/osquery
that referenced
this pull request
Jul 11, 2023
…0 to master * commit '943935789dbfb03b55db1471ed1595e1fd4ffe23': (119 commits) seccomp migrations Add 4.7.0 CHANGELOG (osquery#6985) ATC fails because journal_mode pragma is blocked by sqlite authorizer (osquery#6999) Always use BIGINT macro for 'long long' data (osquery#6986) chrome_extensions: Refactor the table, add tests (osquery#6780) Remove extraneous lenses directory for augues on macOS (osquery#6998) Update the info about macOS CI (osquery#6988) Make Group ID columns consistent across Windows tables (osquery#6987) Fix mem leak regression with Windows' sids API (osquery#6984) Fix error in process_open_files around stoi vs stoul (osquery#6983) Remove hash and yara table from fuzz harnesses (osquery#6972) Augeas Table: Don't autoload system lenses (osquery#6980) Augeas Table: Fix output bug (osquery#6981) Add concat and concat_ws functions (osquery#6927) Copy JSON objects to avoid MemoryPool buildup (osquery#6957) Fix CODEOWNERS syntax to allow committers and TSC (osquery#6975) augeas: Clear aug pointer on error (osquery#6973) Adds support for the computer field in Windows Eventlogs (osquery#6952) Add Shellbags table (osquery#6949) Implementation of VM metadata table for Yandex.Cloud (osquery#6961) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6979 fixing a small regression introduced in #6782 that undid part of #6714
It's easy to forget to free memory with "Caller must free this parameter" APIs like
ConvertStringSidToSidA, fixed before in #6714 (we even forgot to do it in the wrapper we created forConvertSidToSidStringA, see #6548 that fixed that).Because a wrapper for
ConvertSidToSidStringA, I found one place that I changed to use that, instead of the raw API, saving a few lines of code. But in the future, to avoid similar problems withConvertStringSidToSidA, we'd have to make our own wrapper class forsidthat implemented RAII as noted by @Breakwell.