Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GetMemorySize for Windows memory_devices table #7711

Merged

Conversation

josephsweeney
Copy link
Contributor

Uses the std::wcstoull functionality of detecting the base automatically.

@josephsweeney josephsweeney requested review from a team as code owners August 1, 2022 15:40
@mike-myers-tob
Copy link
Member

Btw this is a follow-up to #7633

@mike-myers-tob mike-myers-tob added virtual tables ready for review Pull requests that are ready to be reviewed by a maintainer Windows labels Aug 1, 2022
@mike-myers-tob mike-myers-tob changed the title Fix GetMemorySize for Windows memory_devices table Fix GetMemorySize for Windows memory_devices table Aug 1, 2022
@Smjert Smjert added this to the 5.5.0 milestone Aug 2, 2022
@mike-myers-tob mike-myers-tob merged commit dd00818 into osquery:master Aug 2, 2022
@mike-myers-tob mike-myers-tob deleted the joesweeney/fix-memory-size branch August 2, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Pull requests that are ready to be reviewed by a maintainer virtual tables Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants