Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2:devel / ros2:nightly] install colcon from pip and not apt #272

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
2 participants
@mikaelarguedas
Copy link
Contributor

commented Jun 4, 2019

Related to ros2/ros2#722

Fixes #270

install colcon from pip and not apt
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>

@mikaelarguedas mikaelarguedas referenced this pull request Jun 4, 2019

Merged

Dashing ci #33

@ruffsl

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Would this PR be reverted once the packaging issue with pytest is resolved? I recall we previously migrated away from installing colcon from pip to apt for downstream consistency of dev tools.

Related: pytest-dev/pytest#5389

@mikaelarguedas

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Would this PR be reverted once the packaging issue with pytest is resolved?

Originally the goal is to install all the third-party tools from APT and not pip to allow conflict tracking and automatic upgrade.
In this particular case, I'm not convinced it needs to be reverted.
As this PR targets only the images that are expected to be built daily it shouldn't be too big of a deal to install colcon from pip. It also allows to move away from the error prone pattern of installing some pytest plugins from pip and the others from APT.
I doubt the fix will ever make it to bionic so we will need to install pytest via pip to get it.

@ruffsl

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

I doubt the fix will ever make it to bionic so we will need to install pytest via pip to get it.

Ah, that would do it.
Does this mean that library/ros:dashing images are left with a broken build tool?

@mikaelarguedas

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Does this mean that library/ros:dashing images are left with a broken build tool?

No they should be fine as they dont install any plugins from pip. They just are not able to leverage the various pytest options that colcon provides (I think, I haven't built or tried the dashing images)

@ruffsl

ruffsl approved these changes Jun 4, 2019

@mikaelarguedas mikaelarguedas merged commit 2bd89c7 into master Jun 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mikaelarguedas mikaelarguedas deleted the pytest-workaround branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.