Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static bridge for strings #1

Merged
merged 6 commits into from Aug 26, 2019

Conversation

@shiveshkhaitan
Copy link
Collaborator

commented Aug 11, 2019

This adds a basic bridge for string messages.

To create the bridge

  1. ros2 run ros2_ign_bridge static_bridge
  2. Open an instance of ign gazebo
  3. Create an ignition string msg publisher on topic chatter
  4. ros2 topic echo /chatter

@shiveshkhaitan shiveshkhaitan requested a review from chapulina Aug 11, 2019

README for static bridge
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Collaborator

left a comment

It's looking good!

I added some instructions to the README on bac63db. If you follow them, you'll notice that the ROS 2 -> Ignition direction is not working. I think it could be related to the namespace comment below. Could you give it a try?

ros2_ign_bridge/include/ros2_ign_bridge/factory.hpp Outdated Show resolved Hide resolved
ros2_ign_bridge/src/static_bridge.cpp Show resolved Hide resolved
ros2_ign_bridge/src/builtin_interfaces_factories.cpp Outdated Show resolved Hide resolved
@chapulina chapulina referenced this pull request Aug 14, 2019
@shiveshkhaitan

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 14, 2019

ROS 2 -> Ignition direction is not working

Sorry I forgot to test it the other way around. Fixed in d85a6cd. I missed rclcpp::spin initially

@chapulina
Copy link
Collaborator

left a comment

Works great!

@chapulina chapulina merged commit a33172d into master Aug 26, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@chapulina chapulina deleted the string_bridge branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.