From fae3db90415e99b2510acb5cfb41fe31f37a4bd0 Mon Sep 17 00:00:00 2001 From: Jacob Perron Date: Tue, 10 Nov 2020 15:51:44 -0800 Subject: [PATCH] Enable and fix AsyncParametersClientTest Now we're actually running the tests. This also fixes a bug where we were comparing the wrong objects in one of the tests. Signed-off-by: Jacob Perron --- rcljava/CMakeLists.txt | 1 + .../rcljava/parameters/AsyncParametersClientTest.java | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/rcljava/CMakeLists.txt b/rcljava/CMakeLists.txt index a2a5862f..b357f0d4 100644 --- a/rcljava/CMakeLists.txt +++ b/rcljava/CMakeLists.txt @@ -289,6 +289,7 @@ if(BUILD_TESTING) "org.ros2.rcljava.node.NodeParametersTest" "org.ros2.rcljava.node.NodeUndeclaredParametersTest" "org.ros2.rcljava.node.NodeTest" + "org.ros2.rcljava.parameters.AsyncParametersClientTest" "org.ros2.rcljava.parameters.SyncParametersClientTest" "org.ros2.rcljava.publisher.PublisherTest" "org.ros2.rcljava.qos.QoSProfileTest" diff --git a/rcljava/src/test/java/org/ros2/rcljava/parameters/AsyncParametersClientTest.java b/rcljava/src/test/java/org/ros2/rcljava/parameters/AsyncParametersClientTest.java index 67154902..5bd52bc9 100644 --- a/rcljava/src/test/java/org/ros2/rcljava/parameters/AsyncParametersClientTest.java +++ b/rcljava/src/test/java/org/ros2/rcljava/parameters/AsyncParametersClientTest.java @@ -107,8 +107,14 @@ public final void testSetParameters() throws Exception { List parameterNames = Arrays.asList(new String[] {"foo", "bar", "baz", "foo.first", "foo.second", "foobar"}); + List setParametersResults = future.get(); + assertEquals(6, setParametersResults.size()); + for (rcl_interfaces.msg.SetParametersResult result : setParametersResults) { + assertEquals(true, result.getSuccessful()); + } + List results = node.getParameters(parameterNames); - assertEquals(parameters, future.get()); + assertEquals(parameters, results); } @Test