Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log debug message when jni library is loaded, not info message #69

Merged

Conversation

ivanpauno
Copy link
Collaborator

This is generating ton of logs that doesn't add much value.
I would rather see them only as debug logs than info logs.

Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
@ivanpauno ivanpauno added the enhancement New feature or request label May 13, 2021
@ivanpauno ivanpauno self-assigned this May 13, 2021
Copy link

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@ivanpauno ivanpauno merged commit 097ac64 into galactic-devel May 13, 2021
@ivanpauno ivanpauno deleted the ivanpauno/debug-message-when-loading-jni-library branch May 13, 2021 20:08
ivanpauno added a commit that referenced this pull request May 17, 2021
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
jacobperron pushed a commit to ros2-java/ros2_java that referenced this pull request May 17, 2022
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants