Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for std_msgs/Empty #53

Merged
merged 1 commit into from Nov 22, 2019
Merged

Add support for std_msgs/Empty #53

merged 1 commit into from Nov 22, 2019

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Nov 22, 2019

No description provided.

@chapulina chapulina self-requested a review November 22, 2019 02:21
@chapulina chapulina added the ROS 2 ROS 2 label Nov 22, 2019
mjcarroll
mjcarroll approved these changes Nov 22, 2019
View reviewed changes
Copy link
Collaborator

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but probably not necessary to update the tests here, since they are still ROS1.

@chapulina chapulina merged commit f8c5573 into gazebosim:dashing Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
ROS 2 ROS 2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@azeey @mjcarroll @chapulina